[2.0] [PHP 8.1] Fix deprecated null parameter for string functions in the escape method of the drivers#260
Merged
nibra merged 1 commit intojoomla-framework:2.0-devfrom Jan 22, 2022
Conversation
Contributor
Author
|
Should I make an analogue PR for the 1.0-dev branch? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #
Summary of Changes
Analogue to PR joomla/joomla-cms#36787 for the 3.10-dev branch of the CMS.
Testing Instructions
A code review could be sufficient. Otherwise see joomla/joomla-cms#36787 .
Additional comments
Reading the code I think the return value should be type casted to sting also for the
is_int($text)case a bit above theis_float($text)modified here. (There is no PHP 8.1 error at that place but it would be right due to the function documentation).But that would change behaviour regarding the return value's type in that case, and so I think this should be done with a future clean-up, together with type-hinting the methods.
Documentation Changes Required
None.