Skip to content

[GSoC2025] - Fixing subcategories in the module#637

Merged
alikon merged 4 commits intojoomla-extensions:5.x-devfrom
mahmoudmagdy1-1:sub-categories_module
Jul 12, 2025
Merged

[GSoC2025] - Fixing subcategories in the module#637
alikon merged 4 commits intojoomla-extensions:5.x-devfrom
mahmoudmagdy1-1:sub-categories_module

Conversation

@mahmoudmagdy1-1
Copy link
Copy Markdown
Contributor

Pull Request for Issue #556 .

Summary of Changes

This pr fixes subcategories in the module, allowing to show the hierarchy of the weblinks categories if nested, with an option to choose the limit of child subcategories, also handles an edge case where if the parent category has no weblinks, it doesn't show it
Screenshot from 2025-07-03 23-39-59

Testing Instructions

Create a nested weblinks category structure

  • Level 1
    • Level 2
      • Level 3

Turn on Weblinks Module Group By Subcategories On
You can also choose how deep you in the subcategories you want to view
image

Expected result

image
shows links from all nested categories

Actual result

image
it shows only links from Level 2

Documentation Changes Required

@mahmoudmagdy1-1 mahmoudmagdy1-1 changed the title Fixing subcategories in the module [GSoC2025] - Fixing subcategories in the module Jul 3, 2025
@alikon alikon added the GSoC2025 label Jul 4, 2025
@alikon alikon added this to the Weblinks 5.0.0 milestone Jul 4, 2025
@alikon
Copy link
Copy Markdown
Collaborator

alikon commented Jul 4, 2025

please add system test

alikon
alikon previously requested changes Jul 4, 2025
@alikon alikon dismissed their stale review July 12, 2025 06:34

solved

@alikon alikon merged commit 4968a52 into joomla-extensions:5.x-dev Jul 12, 2025
1 check passed
@alikon
Copy link
Copy Markdown
Collaborator

alikon commented Jul 12, 2025

thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants