Skip to content

Fix Cypress problems related to Joomla 5.3 (mysql)#614

Merged
alikon merged 1 commit intojoomla-extensions:5.x-devfrom
mahmoudmagdy1-1:cypress_5.3.1
Apr 20, 2025
Merged

Fix Cypress problems related to Joomla 5.3 (mysql)#614
alikon merged 1 commit intojoomla-extensions:5.x-devfrom
mahmoudmagdy1-1:cypress_5.3.1

Conversation

@mahmoudmagdy1-1
Copy link
Copy Markdown
Contributor

Pull Request for Issue # .

Summary of Changes

With the release of the Joomla 5.3, a problem was introduced in the Cypress tests, Joomla 5.2 used aria-expanded in the checking of the current active tab in the edit page, but in 5.3 it uses aria-selected, so we need to change the cypress tests to match this

Joomla 5.3.1-dev
image

Joomla 5.2.6-dev
image

Testing Instructions

you can test it locally using npx cypress run

Expected result

Actually checking if the tab is active

Actual result

It doesn't check the active tab and fails, because it was changed in Joomla 5.3

Documentation Changes Required

@mahmoudmagdy1-1 mahmoudmagdy1-1 changed the title Fix Cypress problems related to Joomla 5.3 Fix Cypress problems related to Joomla 5.3 (mysql) Apr 18, 2025
@alikon alikon added this to the Weblinks 5.0.0 milestone Apr 20, 2025
@alikon alikon merged commit d5c3885 into joomla-extensions:5.x-dev Apr 20, 2025
1 check failed
@mahmoudmagdy1-1 mahmoudmagdy1-1 deleted the cypress_5.3.1 branch April 20, 2025 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants