Skip to content

prepare for webservices testings#596

Merged
alikon merged 10 commits intojoomla-extensions:5.x-devfrom
alikon:initial-webservices-tests
Apr 4, 2025
Merged

prepare for webservices testings#596
alikon merged 10 commits intojoomla-extensions:5.x-devfrom
alikon:initial-webservices-tests

Conversation

@alikon
Copy link
Copy Markdown
Collaborator

@alikon alikon commented Mar 30, 2025

Pull Request for Issue # .

Summary of Changes

prepare for webservices automated testings with cypress

Testing Instructions

check if drone happy

Expected result

drone happy

Actual result

N/A

Documentation Changes Required

@Amaan-ali03
Copy link
Copy Markdown

Hi sir , I noticed some tests are failing in this PR. I'd like to help debug and fix the issues if that's alright with you. Let me know if there's anything specific I should be aware of before starting.

@alikon
Copy link
Copy Markdown
Collaborator Author

alikon commented Apr 2, 2025

you are welcome, please go

@Amaan-ali03
Copy link
Copy Markdown

I had a look at the PR, and from what I understand, you're setting up Cypress tests for the Weblinks extension, mainly to test the API and UI parts using Joomla 5.x.
I see that the tests cover version checks, API requests like create/update/delete, and also include setting a secret for bearer token auth.
I’ll start by running the tests locally, check what’s failing, and work on fixing the issues to get everything passing.
Let me know if I'm missing on something ....

@mahmoudmagdy1-1
Copy link
Copy Markdown
Contributor

I found out why the build is failing, It's a typo issue, basically it's looking for JsonapiView, but in the project file it's called JsonApiView, so the solution is to rename the file and class in the path src/api/components/com_weblinks/src/View/Weblinks/JsonApiView.php to JsonapiView
I'm not sure if you can make that change here or if we should open a new pr

@Amaan-ali03
Copy link
Copy Markdown

Amaan-ali03 commented Apr 3, 2025

I found out why the build is failing, It's a typo issue, basically it's looking for JsonapiView, but in the project file it's called JsonApiView, so the solution is to rename the file and class in the path src/api/components/com_weblinks/src/View/Weblinks/JsonApiView.php to JsonapiView I'm not sure if you can make that change here or if we should open a new pr

Thanks for the deep analysis…
I’ll first apply this change and run it locally to see if the build is fixed
If the error is fixed then ig this pr would be enough…

Copy link
Copy Markdown
Contributor

@mahmoudmagdy1-1 mahmoudmagdy1-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we also need to change the class name to JsonapiView

@alikon
Copy link
Copy Markdown
Collaborator Author

alikon commented Apr 3, 2025

@mahmoudmagdy1-1 thanks for checking it

@alikon
Copy link
Copy Markdown
Collaborator Author

alikon commented Apr 3, 2025

stiil a glitch with postgres, i'll check it later when I have some more free time
btw, mysql runs fine

@alikon
Copy link
Copy Markdown
Collaborator Author

alikon commented Apr 3, 2025

@Amaan-ali03 , @mahmoudmagdy1-1 can you check the postgres "glitch" ?
probably yuo'll be much more faster than me 😄

@mahmoudmagdy1-1
Copy link
Copy Markdown
Contributor

@Amaan-ali03 , @mahmoudmagdy1-1 can you check the postgres "glitch" ? probably yuo'll be much more faster than me 😄

yes of course, I'll get on it

@Amaan-ali03
Copy link
Copy Markdown

@Amaan-ali03 , @mahmoudmagdy1-1 can you check the postgres "glitch" ? probably yuo'll be much more faster than me 😄

sure getting it done

@alikon alikon marked this pull request as ready for review April 4, 2025 06:34
room for GSoC project
@alikon alikon merged commit 9ac8bf8 into joomla-extensions:5.x-dev Apr 4, 2025
1 check passed
@alikon alikon deleted the initial-webservices-tests branch April 4, 2025 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants