[4.0] fix help buttons#468
[4.0] fix help buttons#468joomdonation merged 2 commits intojoomla-extensions:4.0-devfrom Bakual:4_FixHelp
Conversation
|
Can't test it.
(After checking & fetching) Got the list of previous issuing tracker, but not from Web Links. Checked also: https://github.com/joomla-extensions/weblinks (Part of Patchtester Component) Checking below, I get Invalid Issue |
|
I honestly don't know how you can test Weblinks. |
|
Thanks ! Now I understand how help works :D. Honestly, I don't know how to use patch tester to test weblinks, too, so I applied the changes manually to test it. Will try to play with patch tester later to see if it could be used to test weblinks PR. Thanks @Bakual for the PR and thanks @ChristineWk for willing to help with testing. |
There is a third variant for help screens where the extension installs the help files directly with the extension. I don't understand yet how that works, probably broken anyway 😀 |
Pull Request for Issue joomla/joomla-cms#35662 (comment)
Summary of Changes
Removing JHELP language strings which were already not present in the INI files. Using hardcoded references like we do in core now.
Adding information for help buttons in categories views and weblink edit form
Removed one help button for the single weblink menuitem as there is currently no help page for that one.
Testing Instructions
Try the various help buttons,
Expected result
they should all work now.
Actual result
Some are missing, some are giving a 404 error
Documentation Changes Required
None