Fix PHP warnings#434
Merged
joomdonation merged 2 commits intojoomla-extensions:masterfrom Aug 18, 2021
Merged
Conversation
Similar to joomla/joomla-cms#27273 Fixes joomla-extensions#433. This PR fixes PHP warnings for the weblinks category view.
|
I have tested this item ✅ successfully on 84ec6b9 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/weblinks/434. |
Contributor
|
Thanks @Harmageddon for your PR. I fixed the issue but we can improve the code abit to save the system from having to query tags data for weblink again. I made commit directly in your PR, hope that is OK With patch applied, the issue is sorted and tags are being displayed as expected, so this PR works and I'm going to merge it.
Thanks |
Author
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to joomla/joomla-cms#27273
Fixes #433.
Summary of Changes
This PR fixes PHP warnings for the weblinks category view.
Testing Instructions
Expected result
No PHP warnings
Actual result
Two times "Warning: Creating default object from empty value"
Documentation Changes Required