mod_weblinks Warning: count(): Parameter must be an array#432
mod_weblinks Warning: count(): Parameter must be an array#432joomdonation merged 2 commits intojoomla-extensions:masterfrom ReLater:patch-2
Conversation
|
Could this be closed? #422? This comment was created with the J!Tracker Application at issues.joomla.org/tracker/weblinks/432. |
|
My pr is only for the module. Looks like #422 is also talking about the component. Therefore: I don't know. |
|
Hi, I installed com_weblinks 4.0.0-dev in Joomla version, 4.0.0-beta8-dev. I receive an error at administrator/index.php?option=com_categories&extension=com_weblinks
Which com_weblinks should I have installed?
|
|
@ReLater If you look at the model class, it could return false https://github.com/joomla-extensions/weblinks/blob/master/src/components/com_weblinks/models/category.php#L76 (in case database failure) and for that case, the error still happens. I updated your PR abit to return empty array for that case. Hope that is OK for you. |
|
Before patch, there is an error
After patch, the error is gone. So I will merge this PR and we can continue working on other issues. Thanks ! |
Summary of Changes
Testing Instructions
Expected result
Actual result
Warning: count(): Parameter must be an array or an object that implements Countable in modules/mod_weblinks/mod_weblinks.php on line 17See: https://github.com/joomla-extensions/weblinks/blob/master/src/modules/mod_weblinks/mod_weblinks.php#L17-L20