Don't hide filter form#389
Merged
joomdonation merged 3 commits intojoomla-extensions:masterfrom Aug 18, 2021
SharkyKZ:master
Merged
Don't hide filter form#389joomdonation merged 3 commits intojoomla-extensions:masterfrom SharkyKZ:master
joomdonation merged 3 commits intojoomla-extensions:masterfrom
SharkyKZ:master
Conversation
Contributor
|
Thanks @SharkyKZ . Tested this change myself and it is the same with what we were doing for version for 4.0-dev, so I'm merging this. Finally, 3 years after the PR was submitted, we got it merged :D.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
Same as joomla/joomla-cms#20126 but for Weblinks.
Testing Instructions
Create some weblinks.
Go to Weblinks Category view in frontend.
Use the filter form with a non-existing keyword so no results are returned.
Expected result
Filter form is available.
Actual result
Filter form is missing, making it impossible to clear the filter.
Documentation Changes Required
No.