Fix replacing every src string / Issue from Weblinks repo#376
Merged
roland-d merged 2 commits intojoomla-extensions:masterfrom Aug 21, 2025
Merged
Fix replacing every src string / Issue from Weblinks repo#376roland-d merged 2 commits intojoomla-extensions:masterfrom
roland-d merged 2 commits intojoomla-extensions:masterfrom
Conversation
This was referenced Mar 27, 2025
cannot mark succesully tested on https://issues.joomla.org/ |
Collaborator
|
@mahmoudmagdy1-1 Thank you for the pull request, this is now merged and will be included in the next release of the Patch Tester. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue 591 from weblinks.
Summary of Changes
When using
patchtesterto test components, it replaces every/srcfolder with empty string (it removes it from the path) but in reality we only need to remove the first/srcoccurrence only, otherwise if the the pull request we checking the changes from has another/srcin it's path its going to get removed and we get this errorThe file marked for modification does not exist, like the issue in the link aboveTesting Instructions
/src