Skip to content

Update asset schema: importmap properties#17

Merged
HLeithner merged 1 commit intojoomla:masterfrom
Fedik:asset-importmap
Jun 25, 2023
Merged

Update asset schema: importmap properties#17
HLeithner merged 1 commit intojoomla:masterfrom
Fedik:asset-importmap

Conversation

@Fedik
Copy link
Copy Markdown
Member

@Fedik Fedik commented Jun 24, 2023

The PR adds properties for importmap.
See joomla/joomla-cms#40714 "ESM importmap support"

@Fedik
Copy link
Copy Markdown
Member Author

Fedik commented Jun 24, 2023

Can test here https://www.jsonschemavalidator.net/
Copy whole schema from the PR, and use your json for assets.
Or this one:

{
  "name": "test",
  "version": "11",
  "description": "description",  
  "assets": [
    {
      "name": "a",
      "type": "script",
      "importmap": true,
      "importmapName": "aaa",
      "importmapScope": "bbb"
    }
  ]	
}

@HLeithner
Copy link
Copy Markdown
Member

the content .gitignore should be part of your global .gitignore file not of this repo

@Fedik
Copy link
Copy Markdown
Member Author

Fedik commented Jun 24, 2023

It a default gitignore we should have in all repos,
Why this repo should have an exception?

@HLeithner
Copy link
Copy Markdown
Member

the content you commit was something that should be in the global ignore file for each person using git but yep true I thought joomla did it the right way but isn't ;-)

@HLeithner HLeithner merged commit c421354 into joomla:master Jun 25, 2023
@HLeithner
Copy link
Copy Markdown
Member

thanks

@Fedik Fedik deleted the asset-importmap branch June 25, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants