Add basic support for sass/scss files to Template manager editing by brianteeman · Pull Request #9871 · joomla/joomla-cms

brianteeman · 2016-04-12T11:17:02Z

Summary of Changes

Add ability to see sass files in the list of available files in the tree
Add ability to create a new file of type sass/scss
Add ability to open, edit and save a sass/scss file

Testing Instructions

Install patch and go to template manager and select a template (not a style)
Select New File from the toolbar
Create a new file and select sass from the file type dropdown
Check that file can be seen in the folder tree and can be selected, edited, saved and deleted

ghost · 2016-04-12T13:30:35Z

I have tested this item 🔴 unsuccessfully on cb02eb7

File cannot be seen, but it exist. Cause make a new File with same Name and Place in Folder got Error

"File with the same name already exists. Failed to create file."

Test on Joomla! 3.5.2-dev

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9871.}

andrepereiradasilva · 2016-04-12T14:03:32Z

I have tested this item ✅ successfully on cb02eb7

Works fine, but i need to many added 'sass' extension to templates "Options" to view the created file in the list os files.

After that i did:

Selected css dir
New file type 'sass' named 'template'
Created and can view and edit it.
_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9871.}

andrepereiradasilva · 2016-04-12T14:08:33Z

BTW you can also have scss file extensions? right?

SCSS is the new version of SASS, i think.
http://sass-lang.com/documentation/file.SASS_REFERENCE.html#syntax

brianteeman · 2016-04-12T16:18:32Z

@andrepereiradasilva yes you can but its not as common

I think I see the problem you both had and I dont know how to fix it. I am adding the file type sass in the options but its not seen until you open and save the options

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9871.}

andrepereiradasilva · 2016-04-12T16:29:03Z

@andrepereiradasilva yes you can but its not as common

Yes, but it seems in the new version, so if adding sass, shouldn't we also add scss?

I think I see the problem you both had and I dont know how to fix it. I am adding the file type sass in the options but its not seen until you open and save the options

i only see two ways: force updating the options parameters in the database on joomla update (IMO not B/C)... or adding a post install message to inform users of the change and what they need to do. I don't like neither. Most users don't even use this options. Is it worth it?

brianteeman · 2016-04-12T16:39:38Z

We could add scss no problem

I think the database update is what has been done before but I am not sure.
Maybe someone else knows. I definitely wouldnt go with the post-install
message

On 12 April 2016 at 17:29, andrepereiradasilva notifications@github.com
wrote:

@andrepereiradasilva https://github.com/andrepereiradasilva yes you can
but its not as common

Yes, but it seems in the new version, so if adding sass, shouldn't we also
add scss?

I think I see the problem you both had and I dont know how to fix it. I am
adding the file type sass in the options but its not seen until you open
and save the options

i only see two ways: force updating the options parameters in the database
on joomla update (IMO not B/C)... or adding a post install message to
inform users of the change and what they need to do. I don't like neither.
Most users don't even use this options. Is it worth it?

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#9871 (comment)

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

andrepereiradasilva · 2016-04-12T16:54:03Z

We could add scss no problem

yes

joomla-cms-bot · 2016-04-12T16:58:09Z

This PR has received new commits.

CC: @andrepereiradasilva, @franz-wohlkoenig

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9871.}

joomla-cms-bot · 2016-04-12T16:58:41Z

This PR has received new commits.

CC: @andrepereiradasilva, @franz-wohlkoenig

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9871.}

brianteeman · 2016-04-12T16:59:23Z

Updated to include scss files

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9871.}

andrepereiradasilva · 2016-04-12T16:59:54Z

I have tested this item ✅ successfully on 5d83f8b

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9871.}

zero-24 · 2016-04-12T17:11:52Z

@brianteeman i don't think we should overrwrite it with a db update as this can ause problems if somone has add / cahnge this setting bevor the update. (e.g. removed some extensions) if we include the db update we revert all changes he made.

So this one will be only for new installs.

The other way arround could be to analyse this setting during the update (script.php) and only add this two values in (if not set bevor) but leave the other one allown.

But i think this is to mich code for a that simple change and if someone is come up and wantbto use it there can be a document page that explains the place to add the extensions.

Another way arround could be a messagebif someone try to create a file with a extesion that is not in the allowed extension setting amd told the user "please add the extension to the settings" or something like that.

zero-24 · 2016-04-12T17:13:23Z

The seccond option would also catch the case that somone manually removend some extensions form that list.

brianteeman · 2016-04-12T17:15:44Z

I agree with your assessment - any idea how to do the second option?

On 12 April 2016 at 18:13, zero-24 notifications@github.com wrote:

The seccond option would also catch the case that somone manually removend
some extensions form that list.

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#9871 (comment)

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

zero-24 · 2016-04-12T19:56:30Z

Please have a look at: brianteeman#9

Add a message if the filetype is allowed but you are not allowed to show it in the backend

joomla-cms-bot · 2016-04-12T20:04:09Z

This PR has received new commits.

CC: @andrepereiradasilva, @franz-wohlkoenig

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9871.}

brianteeman · 2016-04-12T20:09:00Z

I have merged the suggestion from @zero-24 please can you all test again

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9871.}

wilsonge · 2016-04-12T22:26:31Z

administrator/components/com_templates/models/template.php

 			return false;
 		}

-		$explodeArray = explode('.', $fileName);


What was this for and why are we removing it?

OK I'm pretty sure this is going to break the less stuff as $ext is no longer defined for the line below

This was from @zero-24 commit to my repo. Didnt understand it but took him at his word

I think this looks fine with the exception of the removal of these two lines. Was there a reason for it @zero-24 ? Or just a mistake?

Thanks @wilsonge you are correct i have changed this part many times on coding but i miss the final code review see here: brianteeman#10

joomla-cms-bot · 2016-04-13T05:47:37Z

This PR has received new commits.

CC: @andrepereiradasilva, @franz-wohlkoenig

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9871.}

brianteeman · 2016-04-13T05:48:25Z

I have merged @zero-24 latest correction

ghost · 2016-04-13T06:01:01Z

I have tested this item ✅ successfully on 2516589

Tested to create sass/scss-Files on Beez3, Hathor, Isis and Protostar. Got now Message why Files aren't shown.

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9871.}

brianteeman · 2016-04-13T06:43:10Z

And are they shown after you make the change from the message

On 13 April 2016 at 07:01, Franz Wohlkönig notifications@github.com wrote:

I have tested this item [image: ✅] successfully on
2516589
2516589

Tested to create sass/scss-Files on Beez3, Hathor, Isis and Protostar. Got

now Message why Files aren't shown.

This comment was created with the J!Tracker Application
https://github.com/joomla/jissues at issues.joomla.org/joomla-cms/9871
https://issues.joomla.org/tracker/joomla-cms/9871.

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#9871 (comment)

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

ghost · 2016-04-13T08:04:45Z

I thought its enough to know why the Files don't show. I don't know so i have to search how to "append the new File-Extensions in the List of supported Formats at the Template-Options".

brianteeman · 2016-04-13T08:07:49Z

On the main template manager screen select options from the toolbar in the top right.
Then add sass and scss to the list of Valid Source Formats
eg
txt,less,ini,xml,js,php,css,sass,scss

ghost · 2016-04-13T08:21:21Z

Thanks @brianteeman Yes, they are now shown.

brianteeman · 2016-04-13T08:24:51Z

Thanks for testing

On 13 April 2016 at 09:21, Franz Wohlkönig notifications@github.com wrote:

Thanks @brianteeman https://github.com/brianteeman Yes, they are now
shown.

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#9871 (comment)

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

andrepereiradasilva · 2016-04-13T11:45:41Z

so what's needed to test now ?

brianteeman · 2016-04-13T11:49:40Z

@andrepereiradasilva as before but if after applying the patch you have not updated the list of allowed extensions in the options you will still be able to create a file but you cant see it and so a message will be displayed

andrepereiradasilva · 2016-04-13T11:50:24Z

I have tested this item ✅ successfully on 2516589

I think what was left to test is the message when you don't have the filetype in the template config options.

If so, tested successfully.

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9871.}

andrepereiradasilva · 2016-04-13T11:50:46Z

ok, just tested. :)

brianteeman · 2016-04-13T12:11:00Z

RTC

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9871.}

rdeutz · 2016-05-02T06:09:07Z

@brianteeman cloud you please check the merge conflicts, thanks

zero-24 · 2016-05-02T06:44:19Z

administrator/components/com_templates/models/template.php

+	 *
+	 * @return  boolean  true if the extension is allowed false otherwise
+	 *
+	 * @since   3.5.3


@brianteeman can you fix than this since tag to 3.6 too?

# Conflicts: # plugins/editors/tinymce/tinymce.php

joomla-cms-bot · 2016-05-02T09:06:36Z

This PR has received new commits.

CC: @andrepereiradasilva, @franz-wohlkoenig

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9871.}

wojsmol · 2016-05-02T09:16:00Z

@brianteeman Plese remove conficts markers

brianteeman · 2016-05-02T09:26:54Z

Closed see #10186

brianteeman added 2 commits April 12, 2016 12:12

Update config.xml

bde5d10

Update default.php

cb02eb7

joomla-cms-bot added the PR-staging label Apr 12, 2016

add scss value

9e2bf9e

add sccs filetype

5d83f8b

brianteeman changed the title ~~Add basic support for sass files to Template manager editing~~ Add basic support for sass/scss files to Template manager editing Apr 12, 2016

zero-24 added 2 commits April 12, 2016 21:41

Update template.php

e385e93

Update en-GB.com_templates.ini

ae575b1

zero-24 and others added 2 commits April 12, 2016 22:01

Update en-GB.com_templates.ini

a8aaedf

Merge pull request #9 from zero-24/patch-7

2f79bf7

Add a message if the filetype is allowed but you are not allowed to show it in the backend

joomla-cms-bot added the Language Change This is for Translators label Apr 12, 2016

wilsonge reviewed Apr 12, 2016
View reviewed changes

Update template.php

942db3d

joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Apr 13, 2016

brianteeman added this to the Joomla! 3.6.0 milestone Apr 13, 2016

zero-24 reviewed May 2, 2016
View reviewed changes

Merge remote-tracking branch 'joomla/staging' into sass2

8b7758f

# Conflicts: # plugins/editors/tinymce/tinymce.php

brianteeman mentioned this pull request May 2, 2016

Add basic support for sass/scss files to Template manager editing (redo) #10186

Merged

brianteeman removed the RTC This Pull Request is Ready To Commit label May 2, 2016

joomla-cms-bot added the RTC This Pull Request is Ready To Commit label May 2, 2016

brianteeman closed this May 2, 2016

joomla-cms-bot reopened this May 2, 2016

brianteeman removed the RTC This Pull Request is Ready To Commit label May 2, 2016

brianteeman closed this May 2, 2016

rdeutz removed this from the Joomla! 3.6.0 milestone May 2, 2016

brianteeman deleted the sass2 branch May 9, 2016 20:26

Uh oh!

Conversation

brianteeman commented Apr 12, 2016 • edited by joomla-cms-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary of Changes

Testing Instructions

Uh oh!

ghost commented Apr 12, 2016

Uh oh!

andrepereiradasilva commented Apr 12, 2016

Uh oh!

andrepereiradasilva commented Apr 12, 2016

Uh oh!

brianteeman commented Apr 12, 2016

Uh oh!

andrepereiradasilva commented Apr 12, 2016

Uh oh!

brianteeman commented Apr 12, 2016

Uh oh!

andrepereiradasilva commented Apr 12, 2016

Uh oh!

joomla-cms-bot commented Apr 12, 2016

Uh oh!

joomla-cms-bot commented Apr 12, 2016

Uh oh!

brianteeman commented Apr 12, 2016

Uh oh!

andrepereiradasilva commented Apr 12, 2016

Uh oh!

zero-24 commented Apr 12, 2016

Uh oh!

zero-24 commented Apr 12, 2016

Uh oh!

brianteeman commented Apr 12, 2016

Uh oh!

zero-24 commented Apr 12, 2016

Uh oh!

joomla-cms-bot commented Apr 12, 2016

Uh oh!

brianteeman commented Apr 12, 2016

Uh oh!

wilsonge Apr 12, 2016

Choose a reason for hiding this comment

Uh oh!

wilsonge Apr 12, 2016

Choose a reason for hiding this comment

Uh oh!

brianteeman Apr 12, 2016

Choose a reason for hiding this comment

Uh oh!

wilsonge Apr 12, 2016

Choose a reason for hiding this comment

Uh oh!

zero-24 Apr 13, 2016

Choose a reason for hiding this comment

Uh oh!

joomla-cms-bot commented Apr 13, 2016

Uh oh!

brianteeman commented Apr 13, 2016

Uh oh!

ghost commented Apr 13, 2016

Uh oh!

brianteeman commented Apr 13, 2016

now Message why Files aren't shown.

Uh oh!

ghost commented Apr 13, 2016

Uh oh!

brianteeman commented Apr 13, 2016

Uh oh!

ghost commented Apr 13, 2016

Uh oh!

brianteeman commented Apr 13, 2016

Uh oh!

andrepereiradasilva commented Apr 13, 2016

Uh oh!

brianteeman commented Apr 13, 2016

Uh oh!

andrepereiradasilva commented Apr 13, 2016

Uh oh!

andrepereiradasilva commented Apr 13, 2016

brianteeman commented Apr 12, 2016 •

edited by joomla-cms-bot

Loading