JFormFieldUser broken since 3.5.0#9659
JFormFieldUser broken since 3.5.0#9659rdeutz merged 2 commits intojoomla:stagingfrom dgrammatiko:UserField
Conversation
|
I have followed above steps and not able to reproduce this issue. Joomla! Version: Joomla! 3.4.8 Stable [ Ember ] 24-December-2015 19:30 GMT This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9659. |
|
I appreciate you for stepping in @DGT41 :) onclick="if (window.parent && window.parent.jSelectUser) window.parent.jSelectUser(this);"Wherever the following is encountered: data-user-field="<?php echo $this->escape($field);?>"This makes // set the value
$.fieldUser.prototype.setValue = function(value, name) {
this.$input.val(value).trigger('change');
this.$inputName.val(name || value).trigger('change');
};... since the // handle value select
content.on('click', '.button-select', function(){
self.setValue($(this).data('user-value'), $(this).data('user-name'));
self.modalClose();
$('body').removeClass('modal-open');
});... to also remove the HTML attribute would solve it when using Bootstrap Modals? $(this).removeAttr('onclick'); |
|
I have tested this item ✅ successfully on 0fe32ce but please never make me use Hathor again :-P This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9659. |
|
I have tested this item ✅ successfully on 0fe32ce This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9659. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9659. |
|
hathor has template overrides for |
|
I thought about that when I was testing and was able to select the user in On 31 March 2016 at 09:54, Octavian Cinciu notifications@github.com wrote:
Brian Teeman |
|
Isis has layout overrides - Without my proposed changes above this won't be fixed entirely, it will only be fixed for hathor. |
|
Removed RTC This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9659. |
|
This PR has received new commits. CC: @brianteeman, @mikeveeckmans This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9659. |
|
I have tested this item ✅ successfully on d6a8353 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9659. |
|
Tested successfully:
|
|
Set back to RTc - thanks everyone This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9659. |
Pull Request for Issue #9593 .
Summary of Changes
mootools modal needs the field id
Testing Instructions
Switch to the Hathor template. I know it's out of date and never updated, but it serves this point for now. Go to Content > Articles > Add New Article. Click on the User icon next to the Created By field. The Modal window shows up (it should be based on MooTools). Click on any user in there and nothing happens.
Apply patch redo. Also check that isis still works as expected
Kudos to @OctavianC for finding and proposing the solution