Skip to content

Isis: Navbar dropdowns are now scrollable#9375

Merged
wilsonge merged 8 commits intojoomla:stagingfrom
C-Lodder:menu
Apr 6, 2016
Merged

Isis: Navbar dropdowns are now scrollable#9375
wilsonge merged 8 commits intojoomla:stagingfrom
C-Lodder:menu

Conversation

@C-Lodder
Copy link
Copy Markdown
Member

This is a Pull Request for the initial start that @brianteeman made here #9347

Same testing instructions apply

This PR includes RTL support and solves the issue with 3rd level submenus being cropped

@brianteeman
Copy link
Copy Markdown
Contributor

I seem to have an issue with the position of the submenu screen shot 2016-03-11 at 11 32 45


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9375.

@C-Lodder
Copy link
Copy Markdown
Member Author

Hmm, ok, I'll look into this over the weekend

@infograf768
Copy link
Copy Markdown
Member

Another small glitch in RTL (double box):

screen shot 2016-03-12 at 08 47 17

@C-Lodder
Copy link
Copy Markdown
Member Author

@brianteeman - I've fixed the left offset issue you mentioned.
@infograf768 - Fixed the RTL issue

@ot2sen
Copy link
Copy Markdown
Contributor

ot2sen commented Mar 14, 2016

Applied patch to latest stating. The scroll effect doesn´t appear.
j35_scroll_menu_after

@C-Lodder
Copy link
Copy Markdown
Member Author

@ot2sen - This was only supposed to be for the "Components" dropdown.

@brianteeman - Does this need to be applied to all dropdowns?

@ot2sen
Copy link
Copy Markdown
Contributor

ot2sen commented Mar 14, 2016

Perhaps it only is for the Components menu as the title says? Tested the menus menu, which would have same issue often :)

@infograf768
Copy link
Copy Markdown
Member

We also need it indeed for other dropdowns. The menus one is very important.

@brianteeman
Copy link
Copy Markdown
Contributor

@C-Lodder yes it will need to be for all menus (well actually just the menu and components but might as well make it for all)

@C-Lodder
Copy link
Copy Markdown
Member Author

Okies, fixing it up now

@C-Lodder
Copy link
Copy Markdown
Member Author

Applied to all dropdowns

@ot2sen
Copy link
Copy Markdown
Contributor

ot2sen commented Mar 14, 2016

I have tested this item ✅ successfully on 85278b9

Tested successful with latest patch. Menu now scrollable


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9375.

@brianteeman brianteeman mentioned this pull request Mar 14, 2016
@ot2sen
Copy link
Copy Markdown
Contributor

ot2sen commented Mar 14, 2016

Thanks @C-Lodder works now :)
j35_scroll_menu_new_after_ok

@C-Lodder C-Lodder changed the title Components menu dropdown now scrollable Isis: Navbar dropdowns are now scrollable Mar 14, 2016
@joomla-cms-bot
Copy link
Copy Markdown

This PR has received new commits.

CC: @ot2sen


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9375.

@C-Lodder
Copy link
Copy Markdown
Member Author

@ot2sen - There was a slight issue which is now fixed. If you to go "Extensions" >> "Manage", a scrollbar will be added to the dropdown. This was caused by the original <ul> element still being shown. This has been fixed with: f18c456

@ot2sen
Copy link
Copy Markdown
Contributor

ot2sen commented Mar 14, 2016

I have tested this item ✅ successfully on f18c456

Retested with fix for extensions manage. That extra scrollbar is now gone and the intended scrollbars is a menus.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9375.

@MATsxm
Copy link
Copy Markdown

MATsxm commented Mar 14, 2016

I have tested this item ✅ successfully on f18c456

This is just fabulous and a real improvement!

Thanks all and of course @C-Lodder


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9375.

@brianteeman
Copy link
Copy Markdown
Contributor

Working great - do you think there should be some sort of visual indicator at the end of the column to indicate there is more if you scroll?


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9375.

@C-Lodder
Copy link
Copy Markdown
Member Author

@brianteeman - I like to think that people have at least some common sense and know what a scroll bar is for :)

I can add otherwise though

@brianteeman
Copy link
Copy Markdown
Contributor

You only see the scollbar when you over over the menu itself. If you only
click on Menu (or) Component then the scrollbar does not appear so you dont
know the list is truncated

On 14 March 2016 at 16:14, Lodder notifications@github.com wrote:

@brianteeman https://github.com/brianteeman - I like to think they
people have at least some common sense and know what a scroll bar is
for :)

I can add otherwise though


Reply to this email directly or view it on GitHub
#9375 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

@brianteeman
Copy link
Copy Markdown
Contributor

In this screencapture the scrollbar ONLY appears when i try to scroll. Moving up and down or even oving to the end of the menu doesnt indicate there is anything to scroll to

dropdown-menu-bug

@C-Lodder
Copy link
Copy Markdown
Member Author

@brianteeman - Oh, I think that's a Safari feature

Could you try adding the following to the template.css file:

.navbar .nav > li ul::-webkit-scrollbar {
    -webkit-appearance: none;
    width: 7px;
}
.navbar .nav > li ul::-webkit-scrollbar-thumb {
    border-radius: 4px;
    background-color: rgba(0,0,0,.5);
    -webkit-box-shadow: 0 0 1px rgba(255,255,255,.5);
}

Note: this will also style the scroll bar for Chrome and Opera, but will hopefully ensure it's always visible

@brianteeman
Copy link
Copy Markdown
Contributor

Thats perfect- a scrollbar is permanently displayed if there is a scroll available

@joomla-cms-bot
Copy link
Copy Markdown

This PR has received new commits.

CC: @MATsxm, @ot2sen


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9375.

@C-Lodder
Copy link
Copy Markdown
Member Author

@brianteeman - Applied

@brianteeman
Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on 284ebd1


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9375.

@Gerlof
Copy link
Copy Markdown

Gerlof commented Mar 16, 2016

I have tested this item ✅ successfully on 284ebd1


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9375.

@brianteeman
Copy link
Copy Markdown
Contributor

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9375.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 16, 2016
@Djshubh
Copy link
Copy Markdown

Djshubh commented Mar 19, 2016

I have tested this item ✅ successfully on 284ebd1

the scrollbar works for small screens too.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9375.

@brianteeman brianteeman modified the milestones: Joomla 3.5.1, Joomla 3.5.2 Mar 22, 2016
@wilsonge wilsonge merged commit 1af1fe5 into joomla:staging Apr 6, 2016
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Apr 6, 2016
@C-Lodder C-Lodder deleted the menu branch April 6, 2016 09:16
@rdeutz rdeutz modified the milestones: Joomla 3.5.2, Joomla! 3.6.0 May 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants