Skip to content

Tags Manager - Add count and link to tag items#8975

Closed
alikon wants to merge 7 commits intojoomla:stagingfrom
alikon:tag-manager-count
Closed

Tags Manager - Add count and link to tag items#8975
alikon wants to merge 7 commits intojoomla:stagingfrom
alikon:tag-manager-count

Conversation

@alikon
Copy link
Copy Markdown
Contributor

@alikon alikon commented Jan 24, 2016 •
edited by roland-d
Loading

Goal

This PR adds the number of published, unpublished, archived and trashed "content type" in the Tag Manager for the "content type" that have a tag.
Something like works with Categories Manager

After Patch

You can select the tag "content type" alias article, contact, newsfeed, weblink ect
staging administration tags manager

and have a better idea where tags are located
test administration tags manager2

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-staging labels Jan 24, 2016
alikon added 5 commits January 25, 2016 09:51
@alikon
weblink have tags-1
8741a78 
weblink have tags
@alikon
weblink have tags-2
5259a1f 
weblink have tags
@alikon
weblink have tags-3
e0056ef 
weblink have tags
@alikon
weblink have tags-4
ee057f4 
weblink have tags
@alikon
whitespacefix
99be4ac 
whitespace
@alikon alikon changed the title Tag Manager - Added count and link to tag item Tags Manager - Added count and link to tag item Jan 25, 2016
@alikon alikon changed the title Tags Manager - Added count and link to tag item Tags Manager - Add count and link to tag items Jan 25, 2016
@infograf768
Copy link
Copy Markdown
Member

infograf768 commented Jan 25, 2016

please alpha order the new language strings.

@alikon
lang string alpha order
11d355e 
lang string alpha ordered
@alikon
Copy link
Copy Markdown
Contributor Author

alikon commented Jan 26, 2016

language string ordered

@anibalsanchez
Copy link
Copy Markdown
Contributor

anibalsanchez commented Feb 5, 2016

I have tested this item ✅ successfully on 11d355e

It works OK

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8975.

@brianteeman
Copy link
Copy Markdown
Contributor

brianteeman commented Feb 11, 2016

Sorry I dont like - this - Even testing it I found it confusing that the new columns only appear when you have selected a "tag Type" - it is also confusing that you see all the tags when you have selected "tag type" even if the tag is not used for that type. It looks like a filter, its located in the search filters section but it is not a filter.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8975.

@brianteeman
Copy link
Copy Markdown
Contributor

brianteeman commented Feb 11, 2016

I have tested this item 🔴 unsuccessfully on 11d355e

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8975.

@alikon
Copy link
Copy Markdown
Contributor Author

alikon commented Feb 11, 2016

It looks like a filter, its located in the search filters section but it is not a filter.

yes brian is a strange "thing", but it is a wanted behaviour 😆
you can have a better control/map of your tags in this way

how can be improved to be an easy feature ?

@genesisfan
Copy link
Copy Markdown

genesisfan commented Feb 19, 2016

I have tested this item ✅ successfully on 11d355e

Useful to me.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8975.

@brianteeman
Copy link
Copy Markdown
Contributor

brianteeman commented Apr 8, 2016

Set to Needs Review so the maintainers can make a decision

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8975.

@wilsonge
Copy link
Copy Markdown
Contributor

wilsonge commented May 7, 2016

"As is" this shouldn't be merged - we need to use helpers in each component so that custom components can hook into this functionality - look at how we did it for the categories.

@alikon alikon mentioned this pull request Jun 21, 2016
Closed
@alikon
Copy link
Copy Markdown
Contributor Author

alikon commented Jun 21, 2016

closed
please test the new one #10895 with helpers for custom components

@alikon alikon closed this Jun 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Language Change This is for Translators

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@alikon @infograf768 @anibalsanchez @brianteeman @genesisfan @wilsonge @joomla-cms-bot