Skip to content

Protostar Contact display corrections#8612

Closed
infograf768 wants to merge 1 commit intojoomla:stagingfrom
infograf768:contact_protostar
Closed

Protostar Contact display corrections#8612
infograf768 wants to merge 1 commit intojoomla:stagingfrom
infograf768:contact_protostar

Conversation

@infograf768
Copy link
Copy Markdown
Member

This PR corrects 2 issues concerning Single Contact display in Protostar.

Create a contact and link it to a user who has created some articles. Fill all fields. Make sure parameters are set to display all fields. Also Enable User - Profile plugin and fill fields for that user.
Create a Single contact menu item and make sure all fields are set to display.

A. RTL display (to test change en-GB.xml to <rtl>1</rtl>). Thanks @Bakual for that part.

-----------------------------------before patch

before_rtl

-----------------------------------After patch

after_rtl

B. Long article title issue. Screenshots in RTL but it is same in LTR.

-----------------------------------------before patch

before_longname

-------------------------------------------After patch

after_longname

@fontanil
Copy link
Copy Markdown

fontanil commented Dec 8, 2015

There is a problem with this patch: if title is a real title (words AND spaces), before patch it's OK, but after patch line break cuts inside words.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8612.

@fontanil
Copy link
Copy Markdown

fontanil commented Dec 8, 2015

Sorry, picture uploads failed.screen shot 2015-12-08 at 07 20 42


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8612.

@infograf768
Copy link
Copy Markdown
Member Author

@fontanil

I know that. What has been done here was to apply the same css used in the articles manager. That css indeed does not respect spaces anymore and cut words but, if the css is not there, then we have what I have shown above i.e. the title goes all over the page, in the articles manager too.

screen shot 2015-12-08 at 17 26 05

@Bakual
Copy link
Copy Markdown
Contributor

Bakual commented Dec 8, 2015

It's one thing to do that in the backend. But in frontend it looks very wrong to me to break a word.
What is the usecase for such a ridiculuous long article name without any space in it? I doubt there is even a valid case for that. And if so it happens very rarely and could be solved with custom CSS in that particular case.

@infograf768
Copy link
Copy Markdown
Member Author

will create new PR for the RTL issue only...

@infograf768 infograf768 closed this Dec 9, 2015
@infograf768 infograf768 deleted the contact_protostar branch December 9, 2015 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants