Performance gain - new featured article by alikon · Pull Request #8576 · joomla/joomla-cms

alikon · 2015-12-01T06:51:26Z

Follow up

How to reproduce the issue

this issue arise when you create a new article (featured) in a category of 100 or more articles
when you save a new one you should notice that it takes a lot of time

How to test

You need to have 100 articles in one category
at the begin of prepareTable() https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_content/models/article.php#L222 add

JDEBUG ? $time=microtime(true) : null;
JDEBUG ? JLog::addLogger(array('text_file' => 'testPR8576.php', ), JLog::INFO) : null;

at the end https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_content/models/article.php#L243 add

JDEBUG ? JLog::add('prepareTable():'.round(microtime(true) - $time, 3), JLog::INFO) : null;

we do the same on featured() https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_content/models/article.php#L595 add

JDEBUG ? $time=microtime(true) : null;

and

JDEBUG ? JLog::add('Featured():'.round(microtime(true) - $time, 3), JLog::INFO) : null;

at the end

enable the debug plugin
create a new featured article in the category with 100 articles

repeat 5) two or 3 times

in the logs folder open testPR8576.php you'll see how much time cost

Apply the pacth

and redo the same hack 2), 3) as before
repeat 5) two or 3 times
reopen testPR8576.php you should notice the gain

performance gain measurements

i've runned a cli script that create 100 featured articles in 1 category without the patch

it takes something like 500 seconds

i've runned the same script as before with the patch applyed

as you can see now takes only something like 70 seconds

Comments

the $table->reorder() was insanely invoked in the artcle model
and this cause to run a lot of unncessary updates for the ordering field on the #__ content , #__content_frontapage tables

sovainfo · 2015-12-06T12:43:59Z

As requested I performed a code review and it looks ok to me, apart from the fact the comments need to reflect the changed code.

Struggling to determine the impact of your change, not being familiar enough with this part of com_content.

Bodge-IT · 2016-02-15T12:40:37Z

Not seeing these times when creating new featured articles.
Can you be specific for final line number in featured(). Should it sit after "return true;" (L683)
Do the 100 articles all need to be featured?

alikon · 2016-02-15T18:49:41Z

should go before https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_content/models/article.php#L672

if the 100 articles are featured already, the slowness should be more evident

Bodge-IT · 2016-02-15T20:12:29Z

Now have a 109 articles.
New featured articles:
2016-02-15T20:08:33+00:00 INFO 82.69.61.42 - prepareTable():0.865
2016-02-15T20:08:33+00:00 INFO 82.69.61.42 - Featured():0.008
2016-02-15T20:09:40+00:00 INFO 82.69.61.42 - prepareTable():0.87
2016-02-15T20:09:40+00:00 INFO 82.69.61.42 - Featured():0.14
2016-02-15T20:10:14+00:00 INFO 82.69.61.42 - prepareTable():0.952
2016-02-15T20:10:14+00:00 INFO 82.69.61.42 - Featured():0.131

alikon · 2016-02-16T07:02:29Z

are these result from before apply this #pr or after ?
can you publish both results

AmayAgrawal · 2016-02-25T13:08:33Z

Sir you have written that in the logs folder open testpr8576.php but it does not have such file.Can u specify the url or something where should i test.

waader · 2016-02-27T18:41:23Z

I have tested this item ✅ successfully on 0e61eda

Category with 500 featured articles:

results before:
2016-02-27T18:11:43+00:00 INFO 127.0.0.1 - prepareTable():0.872
2016-02-27T18:11:44+00:00 INFO 127.0.0.1 - Featured():0.75
2016-02-27T18:12:02+00:00 INFO 127.0.0.1 - prepareTable():0.78
2016-02-27T18:12:03+00:00 INFO 127.0.0.1 - Featured():0.77

and after:
2016-02-27T18:16:48+00:00 INFO 127.0.0.1 - prepareTable():0.002
2016-02-27T18:16:48+00:00 INFO 127.0.0.1 - Featured():0.012
2016-02-27T18:16:51+00:00 INFO 127.0.0.1 - prepareTable():0
2016-02-27T18:16:51+00:00 INFO 127.0.0.1 - Featured():0.02

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8576.}

webmiep · 2016-04-15T15:21:56Z

I have tested this succesfully

#Date: 2016-04-15 15:09:59 UTC
#Software: Joomla Platform 13.1.0 Stable [ Curiosity ] 24-Apr-2013 00:00 GMT

#Fields: datetime priority clientip category message
----------before patch-----------
2016-04-15T15:09:59+00:00 INFO 159.100.68.158 - prepareTable():0.08
2016-04-15T15:10:21+00:00 INFO 159.100.68.158 - prepareTable():0.116
2016-04-15T15:10:44+00:00 INFO 159.100.68.158 - prepareTable():0.088
-----------after patch-------------
2016-04-15T15:17:00+00:00 INFO 159.100.68.158 - prepareTable():0.001
2016-04-15T15:17:21+00:00 INFO 159.100.68.158 - prepareTable():0.003
2016-04-15T15:17:41+00:00 INFO 159.100.68.158 - prepareTable():0.001

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8576.}

webmiep · 2016-04-15T15:22:29Z

I have tested this item ✅ successfully on 0e61eda

#Date: 2016-04-15 15:09:59 UTC
#Software: Joomla Platform 13.1.0 Stable [ Curiosity ] 24-Apr-2013 00:00 GMT

#Fields: datetime priority clientip category message
----------before patch-----------
2016-04-15T15:09:59+00:00 INFO 159.100.68.158 - prepareTable():0.08
2016-04-15T15:10:21+00:00 INFO 159.100.68.158 - prepareTable():0.116
2016-04-15T15:10:44+00:00 INFO 159.100.68.158 - prepareTable():0.088
-----------after patch-------------
2016-04-15T15:17:00+00:00 INFO 159.100.68.158 - prepareTable():0.001
2016-04-15T15:17:21+00:00 INFO 159.100.68.158 - prepareTable():0.003
2016-04-15T15:17:41+00:00 INFO 159.100.68.158 - prepareTable():0.001

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8576.}

roland-d · 2016-04-15T15:25:17Z

Setting RTC as we have 2 successful commits

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8576.}

new featured article

0e61eda

joomla-cms-bot added the PR-staging label Dec 1, 2015

alikon mentioned this pull request Dec 5, 2015

JTable->reorder is extremely slow #8563

Closed

alikon mentioned this pull request Jan 26, 2016

JTable->reorder is extremely slow #8189

Closed

alikon mentioned this pull request Mar 3, 2016

Article version identity lost after adding another article #9287

Closed

joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Apr 15, 2016

rdeutz added this to the Joomla 3.5.2 milestone Apr 15, 2016

rdeutz merged commit 584440d into joomla:staging Apr 15, 2016

joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Apr 15, 2016

rdeutz modified the milestones: Joomla 3.5.2, Joomla! 3.6.0 May 1, 2016

alikon deleted the performance-1 branch June 7, 2016 06:43

alikon mentioned this pull request Jun 10, 2016

Save new article (create a new ID) very slow in category with many articles #10567

Closed

csthomas mentioned this pull request Jul 13, 2016

New articles are created with last possible "ordering" #11103

Closed

csthomas mentioned this pull request Aug 10, 2016

add flip ordering batch process to category manager #11529

Merged

rdeutz mentioned this pull request Aug 13, 2016

Revert "Performance gain - new featured article" #11581

Merged

rdeutz mentioned this pull request Aug 22, 2016

Fix the ordering of articles and featured #11139

Closed

alikon mentioned this pull request Sep 3, 2016

Reorder tables with single SQL query (all DBs compatible), greatly improving reorder performance #11184

Closed

ggppdk mentioned this pull request Oct 25, 2016

Saving new Article on large category #12552

Closed

csthomas mentioned this pull request Aug 28, 2018

[4.0] Reverse the order of articles in column 'ordering' #21871

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Performance gain - new featured article#8576

Performance gain - new featured article#8576
rdeutz merged 1 commit intojoomla:stagingfrom
alikon:performance-1

alikon commented Dec 1, 2015

Uh oh!

sovainfo commented Dec 6, 2015

Uh oh!

Bodge-IT commented Feb 15, 2016

Uh oh!

alikon commented Feb 15, 2016

Uh oh!

Bodge-IT commented Feb 15, 2016

Uh oh!

alikon commented Feb 16, 2016

Uh oh!

AmayAgrawal commented Feb 25, 2016

Uh oh!

waader commented Feb 27, 2016

Uh oh!

webmiep commented Apr 15, 2016

Uh oh!

webmiep commented Apr 15, 2016

Uh oh!

roland-d commented Apr 15, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Uh oh!

Conversation

alikon commented Dec 1, 2015

How to reproduce the issue

How to test

Apply the pacth

performance gain measurements

Comments

Uh oh!

sovainfo commented Dec 6, 2015

Uh oh!

Bodge-IT commented Feb 15, 2016

Uh oh!

alikon commented Feb 15, 2016

Uh oh!

Bodge-IT commented Feb 15, 2016

Uh oh!

alikon commented Feb 16, 2016

Uh oh!

AmayAgrawal commented Feb 25, 2016

Uh oh!

waader commented Feb 27, 2016

Uh oh!

webmiep commented Apr 15, 2016

Uh oh!

webmiep commented Apr 15, 2016

Uh oh!

roland-d commented Apr 15, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants