[SEO] - Deleted tags not redirecting to 404 error page#8040

Closed

fancyFranci wants to merge 7 commits intojoomla:stagingfrom

fancyFranci:staging

Contributor

fancyFranci commented Oct 9, 2015

A Solution for issue #5148

The issue:
When an url of an unknown tag is requested, joomla handles this like an existing tag with the message "No matching items were found.". A 404 error should be thrown instead.

My solution:
When the tag ID (out of the given url) is searched in the database, I check the primary key of the "found" object. When there is no one, I throw the 404 error, with a "Tag not found." message.

Testing instructions:

Enter an url with a tag that does not exist in your joomla.
Important is the ID and not the name behind the minus.
For example: localhost/example-page/index.php/all-tags/99-foo

Expected result:
A 404 error appears instead of a "No matching items were found." message.

Worked as a group on that issue: @icampus @Flow87 @kathastaden @xsability

Franciska Perisa added 3 commits

October 9, 2015 13:44


          throw error 404 when tag has no existing primary key

d37b84e


          error message 'tag not found' added

10c6758


          Merge remote-tracking branch 'wpw-quality/issue_5148' into staging

dee2046

joomla-cms-bot added Language Change PR-staging labels

Contributor

brianteeman commented Oct 9, 2015

Language strings are normally ordered alphabetically so please can you update the proposed change in the language file

zero-24 mentioned this pull request

[SEO] - Deleted Tags not redirecting to 404 Error page. #5148

Closed

Franciska Perisa added 2 commits

October 9, 2015 15:19


          'search' and 'clear' buttons added

b77232c


          Merge remote-tracking branch 'wpw-quality/issue_5563' into staging

ec507fc

Contributor Author

fancyFranci commented Oct 9, 2015

Thank you for your comment!
I will check my git problems (with the unnecessary commit) and sort the language file.

snarf007 commented Oct 10, 2015

I have tested this item ✅ successfully on ec507fc

Before istalling the patch recieved the following message: No matching items were found.
After installing the patch: No matching items were found. (404 Tag not found. )

Result as expected

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8040.}

Contributor

dam-man commented Oct 10, 2015

I have tested this item ✅ successfully on ec507fc

404 is better to show indeed - Patch is working as expected and throwing a 404 now instead of a message.

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8040.}

Contributor

zero-24 commented Oct 10, 2015

RTC is on hold until @FPerisa gets time to fix the language string ordering ;) Thanks.

zero-24 added this to the Joomla! 3.4.5 milestone

Contributor

roland-d commented Oct 22, 2015

@FPerisa Can you please fix the language ordering so we can merge this fix? Thank you.

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8040.}

frascan commented Oct 24, 2015

I have tested this item successfully; with result as expected.
Test took place in the context of Pizza & Fun Bug JUG Rome.

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8040.}

ZioPal commented Oct 24, 2015

I successfully tested, I think is a sensible change. The test took place in the Pizza and Fun JUG Rome.

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8040.}

Contributor

dgrammatiko commented Oct 24, 2015

@FPerisa can you please merge https://github.com/FPerisa/joomla-cms/pull/1 to move this to RTC?

Franciska Perisa added 2 commits

October 26, 2015 21:22


          orderd language file

7616dd2


          deleted unnecessary changes

e5b4a54

Contributor

dgrammatiko commented Oct 27, 2015

RTC since the language strings are now alpha ordered

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8040.}

joomla-cms-bot added the RTC label

zero-24 modified the milestones: Joomla! 3.4.6, Joomla! 3.5.0

roland-d closed this in

ec14c41

pjwiseman mentioned this pull request

[Accessibility] Joomla Article - Tag: Add 'Search' & 'Clear text' button near search text field #8199

Closed

wilsonge removed the RTC label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Language Change