Use hash_equals for constant-time string comparison#7754
Closed
zero-24 wants to merge 2 commits intojoomla:stagingfrom
zero-24:hash_equals
Closed
Use hash_equals for constant-time string comparison#7754zero-24 wants to merge 2 commits intojoomla:stagingfrom zero-24:hash_equals
zero-24 wants to merge 2 commits intojoomla:stagingfrom
zero-24:hash_equals
Conversation
Contributor
Author
|
Closing because there is no interest. :( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the Codestyle Issues and replaces: #4206 add kudos goes to @dunglas
@committer please mention @dunglas on commit. Thanks
Use the
hash_equalsfunction (introduced in PHP 5.6) for timing attack safe string comparison when available.Add in the DocBlock that length will leak (see php/php-src#792).