[#30214] JLog::add in JFolder::create logs erroneous error messages#756
Closed
alwarren wants to merge 1 commit intojoomla:masterfrom
alwarren:JFolder
Closed
[#30214] JLog::add in JFolder::create logs erroneous error messages#756alwarren wants to merge 1 commit intojoomla:masterfrom alwarren:JFolder
alwarren wants to merge 1 commit intojoomla:masterfrom
alwarren:JFolder
Conversation
Contributor
|
Thanks for coding this, Al! For anyone interested, here's the direct link to tracker item on JoomlaCode: |
Contributor
|
This has now been fixed so can we close the PR please :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In JFolder::create(), there are three instances where a non-date value is sent to the $date parameter of JLog::add().
This results in erroneous DateTime PHP errors in the error log making it difficult to track the source of the error condition.