Skip to content

Adding a Limit Box to Languages Manager: Installed languages#7201

Closed
infograf768 wants to merge 3 commits intojoomla:stagingfrom
infograf768:lang_limit_box
Closed

Adding a Limit Box to Languages Manager: Installed languages#7201
infograf768 wants to merge 3 commits intojoomla:stagingfrom
infograf768:lang_limit_box

Conversation

@infograf768
Copy link
Copy Markdown
Member

@infograf768 infograf768 commented Jun 19, 2015

To test:
Install more than 5 languages via Extension Manager Install.
Go to Modules Manager and set the limit box to 5.
Go to Languages Manager: Installed languages
The # of languages displayed in the list is 5. No way to change it in the manager.

Patch and retest.

@infograf768
Copy link
Copy Markdown
Member Author

infograf768 commented Jun 19, 2015

Screenshot after patch
screen shot 2015-06-19 at 10 41 41

@zero-24 zero-24 mentioned this pull request Jun 19, 2015
Merged
@infograf768
Copy link
Copy Markdown
Member Author

infograf768 commented Jun 19, 2015

Hmm

@zero-24
Copy link
Copy Markdown
Contributor

zero-24 commented Jun 19, 2015

Thanks 😄 Tested successful

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7201.

@brianteeman
Copy link
Copy Markdown
Contributor

brianteeman commented Jun 19, 2015

Tested successfully

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7201.

@brianteeman
Copy link
Copy Markdown
Contributor

brianteeman commented Jun 19, 2015

Setting RTC

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7201.

@brianteeman brianteeman added the RTC This Pull Request is Ready To Commit label Jun 19, 2015
@zero-24 zero-24 modified the milestone: Joomla! 3.4.4 Jul 2, 2015
@Kubik-Rubik
Copy link
Copy Markdown
Member

Kubik-Rubik commented Jul 8, 2015

Looks good for me but could you please correct the indents (line 23 - 30), then I will merge it. Thanks!

@infograf768
Copy link
Copy Markdown
Member Author

infograf768 commented Jul 9, 2015

Which indents?
We have now

<form action="<?php echo JRoute::_('index.php?option=com_languages&view=installed&client=' . $clientId); ?>" method="post" id="adminForm" name="adminForm">
<?php if (!empty( $this->sidebar)) : ?>
    <div id="j-sidebar-container" class="span2">
        <?php echo $this->sidebar; ?>
    </div>
    <div id="j-main-container" class="span10">
<?php else : ?>
    <div id="j-main-container">
<?php endif;?>

If I move all these one indent to the right, then <div id="j-main-container"> will not be aligned anymore with its closing </div>

@Kubik-Rubik
Copy link
Copy Markdown
Member

Kubik-Rubik commented Jul 9, 2015

@infograf768 You are right, thank you. Merged.

@infograf768 infograf768 deleted the lang_limit_box branch July 9, 2015 08:15
@zero-24 zero-24 removed the RTC This Pull Request is Ready To Commit label Oct 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Joomla! 3.4.4

Development

Successfully merging this pull request may close these issues.

5 participants

@infograf768 @zero-24 @brianteeman @Kubik-Rubik @joomla-cms-bot