Skip to content

Fixing content search plugin in PostgreSQL#6972

Closed
Humorlos wants to merge 1 commit intojoomla:stagingfrom
Humorlos:patch-4
Closed

Fixing content search plugin in PostgreSQL#6972
Humorlos wants to merge 1 commit intojoomla:stagingfrom
Humorlos:patch-4

Conversation

@Humorlos
Copy link
Copy Markdown
Contributor

@Humorlos Humorlos commented May 18, 2015

Change to bring search plugin back to work in Postgres SQL as the last to terms are missing in the group by clause.

PostgreSQL. 9.0

Change to bring search plugin back to work in Postgres SQL as the last to terms are missing in the group by clause.
@Bakual Bakual changed the title Update content.php Fixing content search plugin in PostgreSQL May 18, 2015
@Bakual
Copy link
Copy Markdown
Contributor

Bakual commented May 18, 2015

Renamed your PR so it better suites what you did.

Testing

Test the content search plugin (regular search). We need at least one test on PostgreSQL and on MySQLi (to make sure nothing broke).

@alikon
Copy link
Copy Markdown
Contributor

alikon commented May 23, 2015

on postgresql 9.3.5 works as expected without this PR

@dgrammatiko
Copy link
Copy Markdown
Contributor

@test ok MySql here


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6972.

@alikon
Copy link
Copy Markdown
Contributor

alikon commented May 30, 2015

@test and works with this pr too on postgresql 9.3.5

@brianteeman
Copy link
Copy Markdown
Contributor

I am confused. I tested content search on postgres 9.3.5.0 and like @alikon I had no issue so what is the problem that this PR is fixing


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6972.

@Humorlos
Copy link
Copy Markdown
Contributor Author

Humorlos commented Jun 6, 2015

Hello,

the difference is that with Postgresql 9.1 there was a change in regard to the group by of select Statements.

See https://wiki.postgresql.org/wiki/What%27s_new_in_PostgreSQL_9.1 - at the end of the page under "SQL and PL/PgSQL features" there is an example with the changes to the need of group by columns or not.

Similar to that query change there are quite a few in the whole core, who suffer the same problem. I found some of them in the other search plugins and so on.

One way would be to adapt all the SQL queryies, or the raise the overall Joomla requierment from PostgreSQL 8.3.18+ (http://www.joomla.org/about-joomla/technical-requirements.html) up to 9.1.

@alikon
Copy link
Copy Markdown
Contributor

alikon commented Jun 7, 2015

i've suspected something like this, and i'm agree to raise the DB joomla requirements, something similar arise with old mssql too, but i'm afraid that for B/C reason this can be done only for the 4.x,
some feedback from PLT on this?

@brianteeman
Copy link
Copy Markdown
Contributor

Setting to needs review


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6972.

@roland-d roland-d closed this May 7, 2016
@roland-d
Copy link
Copy Markdown
Contributor

roland-d commented May 7, 2016

@Humorlos This is a known issue which cannot be resolved in this version of Joomla. As it is specifically related to using a very old release of the database software on your server the only remedy is to update that to the latest release. Thank you for your report.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6972.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants