Skip to content

Adding back the select box for mobile devices#5627

Closed
zero-24 wants to merge 16 commits intojoomla:stagingfrom
zero-24:patch-8
Closed

Adding back the select box for mobile devices#5627
zero-24 wants to merge 16 commits intojoomla:stagingfrom
zero-24:patch-8

Conversation

@zero-24
Copy link
Copy Markdown
Contributor

@zero-24 zero-24 commented Jan 6, 2015

What this PR do

Implements: #5617 (comment)

And also fix the issue No search button on moblie devices for

  • com_newsfeeds
  • com_tags
  • com_menus (menus view)
  • com_modules

I hope @brianteeman and @aasimali can review

Other issues (out of scope of this PR)

We need a UX / UI Review (what option gets hidden) for the following components but this is out of scope for this PR. (see: #5628)

  • com_redirect
  • com_messages
  • com_banners (Tracks view only)
  • com_search
  • com_finder (filters view only)
  • com_media
  • com_installer (discover, manage, update, updatesites)
  • com_languages

This was referenced Jan 6, 2015
Closed
Closed
@infograf768
Copy link
Copy Markdown
Member

infograf768 commented Jan 7, 2015

@test
Looks good to me

@zero-24 zero-24 mentioned this pull request Jan 7, 2015
Closed
@aasimali aasimali mentioned this pull request Jan 8, 2015
Closed
@zero-24
Copy link
Copy Markdown
Contributor Author

zero-24 commented Jan 8, 2015

@aasimali tested this patch here: #5617 (comment)

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5627.

@zero-24
Copy link
Copy Markdown
Contributor Author

zero-24 commented Jan 8, 2015

As we have two successful tests i moving here to RTC. Thanks to all here!

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5627.

@brianteeman
Copy link
Copy Markdown
Contributor

brianteeman commented Jan 8, 2015

Removing the RTC label for reasons stated in #5643

@infograf768
Copy link
Copy Markdown
Member

infograf768 commented Jan 8, 2015

My test in #5643 were not made with select box on as I confirmed the issue when editing a user and saving.

@zero-24
Copy link
Copy Markdown
Contributor Author

zero-24 commented Jan 8, 2015

Removing the RTC label for reasons stated in #5643

@brianteeman This issue is unrealted to this PR and can also reproduce on the last staging. Please add RTC back here 😄

@infograf768 infograf768 added the RTC This Pull Request is Ready To Commit label Jan 8, 2015
@infograf768
Copy link
Copy Markdown
Member

infograf768 commented Jan 8, 2015

adding it back indeed.

@infograf768
Copy link
Copy Markdown
Member

infograf768 commented Jan 8, 2015

merged, thanks.

@zero-24
Copy link
Copy Markdown
Contributor Author

zero-24 commented Jan 8, 2015

Thanks @infograf768

@zero-24 zero-24 deleted the patch-8 branch January 8, 2015 11:08
@brianteeman
Copy link
Copy Markdown
Contributor

brianteeman commented Jan 8, 2015

Sorry for the confusion

On 8 January 2015 at 11:08, zero-24 notifications@github.com wrote:

Thanks @infograf768 https://github.com/infograf768

—
Reply to this email directly or view it on GitHub
#5627 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

@wilsonge wilsonge added this to the Joomla! 3.4.0 milestone Feb 8, 2015
@zero-24 zero-24 removed the RTC This Pull Request is Ready To Commit label Oct 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Joomla! 3.4.0

Development

Successfully merging this pull request may close these issues.

5 participants

@zero-24 @infograf768 @brianteeman @wilsonge @jissues-bot