[fix] #5554, Adding tags when editing articles.#5601
[fix] #5554, Adding tags when editing articles.#5601jackkum wants to merge 1 commit intojoomla:stagingfrom
Conversation
|
@test success! |
|
This might fix the issue but is a horrific hack. This effectively nulls the entire where statement. In which case you may as well remove it all together (but not sure if that is the right answer either) |
|
@wilsonge |
|
Why not use "where" like zf? |
|
We do have a second parameter for where (https://github.com/joomla/joomla-cms/blob/staging/libraries/joomla/database/query.php#L1492) |
|
it is apply for all where conditions. $query = $db->getQuery(true);
$query->select('*');
$query->from('...');
$query->where('cond', 'OR');
$query->where('cond1', 'AND');
$query->where('cond2');
// result will be select * from ... where cond OR cond1 OR cond2 |
|
on zf this will be $query = $db->select();
$qurey->from('...');
$query->where('cond');
$query->orWhere('cond1');
$query->where('cond2');
// result will be select * from ... where (cond) OR (cond1) AND (cond2) |
|
Agree with @jackkum here. We have second argument but it applies to all where. So, if we want to write query with |
|
For me it works as it should. This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5601. |
|
I'm closing this as it's completely the wrong fix as I described. We need to rewrite this query properly rather than adding this statement |
|
I am not very familiar with the internals of com_tags, but this seems rather like a limitation and not a bug. You can later add tags if you write 3 letters from the tag it will be displayed. If this PR is not updated in the next 30 days, it would be closed, as it cannot be merged in the current state. This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5601. |
|
@vdespa i think you are commenting on the wrong issue ^.^ |
#5554 and #5455