B/C issue on $app->redirect($url, $msg)#5247
Closed
cyrez wants to merge 1 commit intojoomla:stagingfrom
Closed
Conversation
I've found a B/C issue in 3.4.0-alpha related to a change done in /libraries/joomla/application/web.php, line 549 joomla#4292 If a third-party extension uses the deprecated $app->redirect($url, $msg), as $msg is not numeric, it will return a error <b>0 You have not supplied a valid HTTP 1.1 status code</b>
Contributor
|
I think you are mixing things redirect($url, $msg) is for the controller, app->redirect doesn't has a msg. |
Contributor
Author
Ok... i think i'm wrong... 👎 But shame on me... it is a very crap way of using redirect... Thanks for your comment! ;-) |
cyrez
referenced
this pull request
Dec 2, 2014
Change language string names Add extra large class to field Don't check for empty new url if in advanced mode Remove not null constraint in db Remove not null constraint in db (2/2) Add extra check for a 3xx code Port to all databases Add missing update files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've found a B/C issue in 3.4.0-alpha related to a change done in /libraries/joomla/application/web.php, line 549 #4292
If a third-party extension uses the deprecated $app->redirect($url, $msg), as $msg ($status) is not numeric, it will return an error 0 You have not supplied a valid HTTP 1.1 status code