@test: Tested successfully.
tested on all browsers
tested LTR and RTL

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5141.

Thank you @yanivRozenman
Could you revert and patch again ?
I've just changed compression of core.js for Travis to succeed. ;-)

@JoomliC
seem to be ok after repatching :)

@test succesful. 👍 for the fade in effect on the icons!
UPD: Latest Safari, Chrome, FF, Opera on OSX

In my test I'm experiencing inline scroll in the sidebar:

And could there perhaps be added some more padding around the dropdown's?

Great work btw :)

In the screenshot from #4450 you had a gradient background, did you remove that again?

@JoomliC Well done !! I have tested this on Windows + FF + Chrome + IE and works as expected. I agree with @losedk the gradient would be nice to have and some padding around the dropdowns will make them look better.

@losedk i've updated to fix your issue. Could you test again if you don't have again the inline scroll (not needed in fact...)

@losedk and @roland-d i have added back the same gradient as for the toolbar background. Thanks for your feedback about it, i was not sure it was best to have the gradient or not. ;-)

@JoomliC Cool! But the filters could still use some padding :)

After a discussion with @nternetinspired @phproberto @Bakual, i have updated the PR to use only css transition, with better performance.
Only IE8 is not css transition compatible, but it's not an issue, IE8 can do without transitions.

@DGT41 So, as we have requested before, it's not a problem if no transition on ie8 as far as we can use the sidebar without issue. ;-)

@infograf768 No changes for com_localise ;-)

@nternetinspired I've tried to use http://getbootstrap.com/2.3.2/javascript.html#collapse. But it was really a headache to make it working as expected due to where the sidebar layout is loaded. I'm afraid we could have B/C issue with third party extensions (if toggle button is loaded in submenu layout) or not sure it could be good to load the button in the template index.php or elsewhere...
In fact, this could be a future improvement, with most time to check UX, and speak about it! (i will re-install my Skype to speak about a few ideas with @phproberto too ;-) )

Yes, it's better to add a class to the element as a hook for css, e.g. div id="j-toggle-button-wrapper" class="j-toggle-button-wrapper" so that your css can target .j-toggle-button-wrapper instead.
This keeps specificity low in the cascade. An ID selector in CSS is a trump, overruling element and class selectors, which ultimately leads to stylesheet bloat and angry front-enders :) ."

Done!
Note: the only way I saw about how to have a class .j-sidebar-container for div #j-sidebar-container (view) was to add class with js, and remove span2... is it correct ?

And nice week-end to all!
Cyril

works fine here...

@test again on OS X FF chrome safari opera Success
Win IE8 (virtual box) Success
👍

@test Works as expected here.

Since this is already RTC, I think we can really move this forward now.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5141.

@JoomliC Thanks for moving transition effects to css and for using class selectors. This is really a huge improvement I think. 🙇

…In fact, this could be a future improvement, with most time to check UX, and speak about it! (i will re-install my Skype to speak about a few ideas with @phproberto too ;-) )

Yes, let's look at this for a future PR. No need to further delay this one, given that it is such a big improvement already.

I'd be happy to collaborate with you on any further improvements, if you want. My skype is seths_laptop ;)

Thanks to all. Merged at last! 👍

Happy New JYear! to All !!!

@nternetinspired @phproberto @DGT41 I've requested you as contact on Skype (it was the first time i requested someone on this app i've never really used...)
My Skype : cyril_reze

Cyril

One of the biggest things in regards to the sidebar that many are telling me is 2 things:

1: It doesn't scroll with the page when it feels like it should.
2: The small toggler to open doesn't stand out and gets lost on the page. So I am attaching a mock thanks to Kelsey Brookes

Should I open a issue?