Experimental version of the Language Filter#5110
Experimental version of the Language Filter#5110smanzi wants to merge 5 commits intojoomla:stagingfrom
Conversation
…renderModal
An optional argument is added to JHtmlBootstrap::renderModal that allows
to select if the close button ("x") should be displayed or not.
The functionality of the "backdrop" parameter in JHtmlBootstrap::modal
is extended to allow displaying a 'static' (no close on click) backdrop.
…tstrap::renderModal" This reverts commit 8eb2da5.
|
Sorry: there are some "spurious" commits above this one as I did some mistake in my local repo, but it seems to me that, having reverted the spurious ones, everything should be OK here. Is there a way to get rid of that garbage I involuntary created? Thanks to whomever will help... |
|
Please, see #5109 as well: they go somehow together... |
Still a very experimental version of the language filter The main reason to exists is now trying to get rid of the language cookies I reverted the HTTP status code returned in case of redirect to 303
|
Sorry, guys, I have changed everything: the main purpose of this PR is now trying to get rid of the Language Cookies. |
|
To get rid of the lang cookies, here is a patch: BUT it must be clear that getting rid of the language cookie means that it is ALWAYS the default site Language or the Browser settings that will be used when going back to the bare url without language code. That is most of the time unwanted. |
|
Could you please provide an overview of what this patch hopes to achieve, what we should see before the patch is applied, and what would show a successful test? It would help enormously for testers who don't know what you're proposing to fix. |
|
@RCheesley Beside that there is an ongoing discussion if redirects from the language_filter (I.e. redirects for functioning but not canonical URLs) should return an HTTP status code of 303 (as it is now) or 301 |
|
I'm closing this PR. |
This a very preliminary PR (I guess it will not even pass Travis because of some "work in progress" comments in it). It supersedes #5092 that didn't take into account every case.
I think there will be much to discuss about this...