[6.1] Enhance translation handling in Workflow component#47299
Merged
tecpromotion merged 2 commits intojoomla:6.1-devfrom Mar 9, 2026
Merged
[6.1] Enhance translation handling in Workflow component#47299tecpromotion merged 2 commits intojoomla:6.1-devfrom
tecpromotion merged 2 commits intojoomla:6.1-devfrom
Conversation
Contributor
|
I have tested this item ✅ successfully on 8e654a3 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47299. |
Contributor
adarshdubey03
left a comment
There was a problem hiding this comment.
Tested successfully on Joomla 6.1-dev.
Steps tested
- Enabled Workflows
- Enabled Language Debug
- Opened the workflow graph
- Created stages and transitions
- Tested removing stages/transitions
Results
The workflow graph renders correctly and no "undefined" values appear in the transition labels.
The confirmation dialog shows translated "Yes" and "No" buttons when language debug is enabled.
Additionally verified via console:
Joomla.Text._('JYES') → Yes
No regressions observed. Patch works as expected.
Contributor
|
I have tested this item ✅ successfully on 8e654a3 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47299. |
Member
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47299. |
Contributor
|
Thanks @Dileepadari @brianteeman and @adarshdubey03 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request resolves #47231.
Summary of Changes
Enhance translation handling in Workflow component
Testing Instructions
This requires either
npm cior testing with a prebuilt packageEnable language debug
Enable Workflows
Open the workflow graph
There should be no undefined tags in the flow. The yes and no buttons in confirmation when clicked on remove stage or transition should be a language string like yes or no
Actual result BEFORE applying this Pull Request
Transition: Write Article,Idea,Copywriting from stage undefined to undefined. Status of transition Write Article: Enabled.
Expected result AFTER applying this Pull Request
Transition: Write Article from stage Idea to Copywriting. Status of transition Write Article: Enabled.
Link to documentations
Please select:
Documentation link for guide.joomla.org:
No documentation changes for guide.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed