[6.0] Prevent error if ListView does not have filter form#46689
Merged
Bodge-IT merged 2 commits intojoomla:6.0-devfrom Jan 25, 2026
Merged
[6.0] Prevent error if ListView does not have filter form#46689Bodge-IT merged 2 commits intojoomla:6.0-devfrom
Bodge-IT merged 2 commits intojoomla:6.0-devfrom
Conversation
Member
|
@joomdonation As this PR is made for the 6.0-dev branch: Is this a bug fix specific for 6.x? or does the issue which it fixes also exist in 5.4-dev? In this case the PR should be made for the 5.4-dev branch. Or if it counts as a new feature, then for the 6.1-dev branch. See https://github.com/joomla/joomla-cms?tab=readme-ov-file#which-branch-should-my-pull-request-target . |
Contributor
Author
|
@richard67 It is a bug fix for 6.0-dev branch only. The issue was introduced by my PR for 6.0-dev #46165 |
Contributor
|
I have tested this item ✅ successfully on adb8c1b This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46689. |
1 similar comment
Member
|
I have tested this item ✅ successfully on adb8c1b This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46689. |
Member
|
rtc This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46689. |
4 tasks
Contributor
|
Thanks @joomdonation for fixing, thanks @ceford & @Fedik for tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
Extensions can use the
ListViewclass without defining a filter form. In this case, the$filterFormproperty remainsnull, which can lead to a fatal error when the view attempts to access it without a null check.This PR adds a guard check to safely handle the absence of a filter form and prevent a fatal error.
Testing Instructions
com_items.zip
Actual Result BEFORE Applying This Pull Request
You got fatal error Call to a member function addControlField() on null due to missing null check in
ListViewclassExpected Result AFTER Applying This Pull Request
No error anymore. You see a screen displays list of items (empty until you add items to it). You might see a warning
Deprecated: substr(): Passing null to parameter #1 ($string) of type string is deprecated inbut ignore it for now. The main thing is fatal error is sorted by this PR.Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed