[5.3] Choices force background#45842
Merged
richard67 merged 2 commits intojoomla:5.3-devfrom Aug 7, 2025
Merged
Conversation
Signed-off-by: BrianTeeman <brian@teeman.net>
|
I have tested this item ✅ successfully on dd0875f This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45842. |
Contributor
|
I have tested this item ✅ successfully on dd0875f This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45842. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45842. |
Member
|
Thanks all (author and testers). |
Contributor
Author
|
thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #45765 .
Summary of Changes
Force the choices background to be used even when mobile otherwise the selected choice is invisible
This is caused by a conflicting css rule that is triggered on mobile and gets priority
joomla-cms/build/media_source/templates/administrator/atum/scss/vendor/joomla-custom-elements/joomla-tab.scss
Lines 264 to 266 in 36516f6
Someone with better css skills than me might have an alternative/better solution
Testing Instructions
Add a tag to an article and check that when on mobile (small screen) you can still see the selected tag
this is an scss change so you will either need to
npm run build:cssor use a prebuilt packageActual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed