Serve correct 404 status for URLs with invalid controller name#45646
Merged
rdeutz merged 2 commits intojoomla:5.3-devfrom Aug 1, 2025
Merged
Serve correct 404 status for URLs with invalid controller name#45646rdeutz merged 2 commits intojoomla:5.3-devfrom
rdeutz merged 2 commits intojoomla:5.3-devfrom
Conversation
Contributor
|
I have tested this item ✅ successfully on 963fbd1
After applying the PR:
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45646. |
Contributor
|
I have tested this item ✅ successfully on 963fbd1 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45646. Before
After
|
Member
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45646. |
|
I have tested this item ✅ successfully on 963fbd1 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45646. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Currently, if a page is loaded with
taskhandling invalid controller, Joomla reports 500 server error status.But logically, it should be a 404 response, but not a server error.
For instance, I have a custom notifier on server errors, but it's just an invalid URL, or it could be an old URL with menu item type changes. Once indexed by search engine, it will send you 500 errors.
Testing Instructions
Load any usual single article URL with appended invalid task like
?task=foo.bar, i.e.:https://www.joomla.org/announcements/release-news/5928-joomla-5-3-1-bugfix-release.html?task=foo.bar
Actual result BEFORE applying this Pull Request
Invalid URL returns 500 status.
Expected result AFTER applying this Pull Request
Invalid URL returns 404 status.
Link to documentations
Please select:
No documentation changes for docs.joomla.org needed
No documentation changes for manual.joomla.org needed