Removed hardcoded username from Actionlogs.cy.js#44439
Merged
laoneo merged 3 commits intojoomla:5.2-devfrom Nov 12, 2024
pAnd0rASBG:patch-1
Merged
Removed hardcoded username from Actionlogs.cy.js#44439laoneo merged 3 commits intojoomla:5.2-devfrom pAnd0rASBG:patch-1
laoneo merged 3 commits intojoomla:5.2-devfrom
pAnd0rASBG:patch-1
Conversation
On line #22 "ci-admin" was hardcoded, causing the test to fail, if another user is configured in cypress.config.mjs
Member
|
@pAnd0rASBG Could you check and fix the javascript codestyle error reported by Drone here https://ci.joomla.org/joomla/joomla-cms/80258/1/20 ? |
Using Template Literals to pass JS linting
Contributor
Author
|
I changed the Syntax to not use the concatenation Drone was complaining about. However - I don't see why it's failing now with "Unexpected token username" as this is the Variable from Cypress' config and the test works perfectly like that. |
richard67
reviewed
Nov 11, 2024
tests/System/integration/administrator/components/com_actionlogs/Actionlogs.cy.js
Outdated
Show resolved
Hide resolved
…gs/Actionlogs.cy.js Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
Contributor
Author
|
Thanks @richard67 👍 |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On line 22 "ci-admin" was hardcoded, causing the test to fail, if another user is configured in cypress.config.mjs
Summary of Changes
replaced ci-admin with Cypress.env('username')
Testing Instructions
Configure cypress.config.mjs to user other than "ci-admin"
Actual result BEFORE applying this Pull Request
"can display a list of actions" will fail due to "ci-admin" not being found in log
Expected result AFTER applying this Pull Request
Test will pass, due to searching for the actual username
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed