Skip to content

[5.1] Useless isset argument#41968

Merged
LadySolveig merged 5 commits intojoomla:5.1-devfrom
Denitz:5.0_Useless_isset_argument
Jan 29, 2024
Merged

[5.1] Useless isset argument#41968
LadySolveig merged 5 commits intojoomla:5.1-devfrom
Denitz:5.0_Useless_isset_argument

Conversation

@Denitz
Copy link
Copy Markdown
Contributor

@Denitz Denitz commented Sep 28, 2023

Summary of Changes

Remove useless isset argument.

Testing Instructions

Apply patch.

Actual result BEFORE applying this Pull Request

Useless isset argument.

Expected result AFTER applying this Pull Request

No useless isset arguments.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@HLeithner HLeithner changed the title [5.0] Useless isset argument [5.1] Useless isset argument Sep 30, 2023
@HLeithner HLeithner changed the base branch from 5.0-dev to 5.1-dev September 30, 2023 22:48
@HLeithner
Copy link
Copy Markdown
Member

This pull request has been automatically rebased to 5.1-dev.

@rdeutz rdeutz added Maintainers Checked Used if the PR is conceptional useful PR-5.1-dev and removed PR-5.0-dev labels Jan 11, 2024
@rdeutz rdeutz self-requested a review January 11, 2024 12:10
@Quy
Copy link
Copy Markdown
Contributor

Quy commented Jan 11, 2024

I have tested this item ✅ successfully on 54bfe19


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41968.

1 similar comment
@viocassel
Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on 54bfe19


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41968.

@Quy
Copy link
Copy Markdown
Contributor

Quy commented Jan 16, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41968.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 16, 2024
@LadySolveig LadySolveig added this to the Joomla! 5.1.0 milestone Jan 29, 2024
@LadySolveig LadySolveig merged commit af1ca89 into joomla:5.1-dev Jan 29, 2024
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 29, 2024
@LadySolveig
Copy link
Copy Markdown
Contributor

Thank you @Denitz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature Maintainers Checked Used if the PR is conceptional useful

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants