[5.1] resolve todo image filter#41885
Merged
LadySolveig merged 6 commits intojoomla:5.1-devfrom Dec 6, 2023
Merged
Conversation
As we are now using php8 the TODO has been resolved and the code can be removed See comment joomla#28694 (comment)
Member
|
This pull request has been automatically rebased to 5.1-dev. |
Contributor
|
I have tested this item ✅ successfully on 9fda474 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41885. |
1 similar comment
Contributor
|
I have tested this item ✅ successfully on 9fda474 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41885. |
Member
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41885. |
Contributor
|
Hi @brianteeman I was wondering if it should be updated here as well: |
Contributor
Author
|
afaict its a different thing but i could be wrong. I was just following the information in the todo notice |
Contributor
|
Thanks @brianteeman, Let's do an internal check and I'll update you |
Contributor
Author
|
whichever you decide any changes to those files are beyond the scope of this PR and should be handled in their own pr as they are nothing to do with the title of this PR |
Contributor
|
Thank you @brianteeman ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove check for resource when we only support PHP 8