[5.0] Do not force old XTD buttons to use new modal#41633
Merged
HLeithner merged 3 commits intojoomla:5.0-devfrom Sep 17, 2023
Merged
[5.0] Do not force old XTD buttons to use new modal#41633HLeithner merged 3 commits intojoomla:5.0-devfrom
HLeithner merged 3 commits intojoomla:5.0-devfrom
Conversation
2 tasks
Contributor
|
Works! but please note this: #40202 (comment) |
Contributor
|
I have tested this item ✅ successfully on be649dc I see the slight difference in appearance of the two layouts and the different implementation. Both work fine in selecting a Contact to insert into an article. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41633. |
Conflicts: plugins/editors/tinymce/src/PluginTraits/XTDButtons.php
Member
@Ruud68 thanks for your comment I answered it in the issue maybe not the ideal solution for you but hard to solve all issues without resources. thanks @Fedik and testers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
In #40202 was added code that allows to show old XTD buttons in new Dialog, when
$button->modal = true.Hovewer this does not work good.
I removing this part here.
Now a new modal will work only when button explicitly set
$button->action = 'modal'.Testing Instructions
Edit Contact XTD button
joomla-cms/plugins/editors-xtd/contact/src/Extension/Contact.php
Line 60 in aa52c06
Change to:
Go to article ediiting and click this button.
Actual result BEFORE applying this Pull Request
You get a new Dialog modal
Expected result AFTER applying this Pull Request
You get BS modal.
Link to documentations
Please select:
Reference: