[5.0] Realistic test for import maps#41018
Closed
dgrammatiko wants to merge 13 commits intojoomla:5.0-devfrom
Closed
[5.0] Realistic test for import maps#41018dgrammatiko wants to merge 13 commits intojoomla:5.0-devfrom
dgrammatiko wants to merge 13 commits intojoomla:5.0-devfrom
Conversation
Co-authored-by: Brian Teeman <brian@teeman.net>
3 tasks
81fd4cb to
04a2985
Compare
Member
|
for easier diff read: |
Member
|
thanks |
Member
|
can you please resolve the conflicts #40714 has been merged |
04a2985 to
4661892
Compare
Contributor
Author
|
Replaced by #41034 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
THIS SHOULD NOT BE MERGED. IT'S JUST FOR DEMOING THE IMPORT MAPS
Summary of Changes
Check the showon script: it's split to 2 files, the class and the initiator
Testing Instructions
Open the global config and check that the Site Offline still works
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
@HLeithner