Tags router: unset Itemid for not matching menu, in the end of build#40455
Tags router: unset Itemid for not matching menu, in the end of build#40455sdwjoomla merged 1 commit intojoomla:4.3-devfrom
Conversation
|
Tested, issue resolved, no itemid on pagination as well. I didn't used the file it self, just changed line 185 since lines 155-157 brakes the site. 155-157 original: 155-157 in the file here: |
|
@ch2856 Could you go to the issue tracker here https://issues.joomla.org/tracker/joomla-cms/40455 , then use the blue "Test this" button at the top left corner, and then select your test result (success as far as I understood) and finally submit? Thanks in advance. |
|
I have tested this item ✅ successfully on 24e6776 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40455. |
|
@ch2856 Thank you very much for testing. |
|
I have tested this item ✅ successfully on 24e6776 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40455. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40455. |
|
I've remove the release blocker label because as far as I can see the pagination links had the |
|
As far as I remember, before J4 we had no itemid using pagination. Since J4 the pagination for tags was broken so the solution here is the right one. |
@ch2856 As you can see I have successfully tested this PR, so I have no doubt that it is right and good. What I meant is that it's not a release blocker due to our definitions. |
Pull Request for Issue #40442 redo of #40448 .
Summary of Changes
Other way around,
Unset Itemid for not matching menu, in the end of Router::build.
Testing Instructions
Please follow #40442
Also open Tags list URL /component/tags/tags and check paginations links (Tag menu should be unpublished or not exists)
Actual result BEFORE applying this Pull Request
the url contain
ItemidExpected result AFTER applying this Pull Request
the url does not contain
ItemidLink to documentations
Please select: