[4.3] Fix error from #39537 [a11y]#40323
Merged
wilsonge merged 2 commits intojoomla:4.3-devfrom Apr 3, 2023
Merged
Conversation
You can't have two buttons with the same text that do different things. I am assuming that this change was made in error by @wilsonge in joomla#39537 ### Joomla 4.29 ### Joomla 4.3 before this PR ### Joomla 4.3 after this PR
Contributor
|
I have tested this item ✅ successfully on 98105dc This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40323. |
1 similar comment
Contributor
|
I have tested this item ✅ successfully on 98105dc This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40323. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40323. |
Contributor
|
Yup looking at it I'd assume I made a mess of it too. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You can't have two buttons with the same text that do different things. I am assuming that this change was made in error by @wilsonge in #39537
Joomla 4.29
Joomla 4.3 before this PR
Joomla 4.3 after this PR
Pull Request for Issue # .
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed