[4.4] Introduce local variables to replace repeating method calls#40224
Merged
laoneo merged 5 commits intojoomla:4.4-devfrom Mar 29, 2023
Merged
[4.4] Introduce local variables to replace repeating method calls#40224laoneo merged 5 commits intojoomla:4.4-devfrom
laoneo merged 5 commits intojoomla:4.4-devfrom
Conversation
sandewt
reviewed
Mar 28, 2023
sandewt
reviewed
Mar 28, 2023
sandewt
reviewed
Mar 28, 2023
sandewt
reviewed
Mar 28, 2023
Member
|
I'm not sure if there should be a blank line before the if blocks. Beside that it looks good! Thanks. |
laoneo
reviewed
Mar 28, 2023
…nation/joomla-cms into introduce_local_variables
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
This PR introduces local variables
$appand$dbto replace the repeating calls$this->getApplication()and$this->getDatabase(). phpstorm has a built-in function called Refactor -> Introduce Variable allows us to do this quickly. We do not have a clear rule for this, but I think doing that would make code more cleaner and a little faster.Testing Instructions
Actual result BEFORE applying this Pull Request
Works
Expected result AFTER applying this Pull Request
Works with cleaner code and a little faster.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed