Skip to content

[4.4] Make code consistent, change <folder>services</folder> to <folder>src</folder>#40204

Merged
laoneo merged 7 commits intojoomla:4.4-devfrom
sandewt:patch-9
Mar 28, 2023
Merged

[4.4] Make code consistent, change <folder>services</folder> to <folder>src</folder>#40204
laoneo merged 7 commits intojoomla:4.4-devfrom
sandewt:patch-9

Conversation

@sandewt
Copy link
Copy Markdown
Contributor

@sandewt sandewt commented Mar 26, 2023

Pull Request for Issue # .

Summary of Changes

Match code in some .xml files with what is most common in Joomla
Swap services to src

Testing Instructions

  • works
  • code review

Actual result BEFORE applying this Pull Request

Module(s)

<folder module="mod_example">src</folder>
<folder>services</folder>

Plugin(s)

<folder>services</folder>
<folder plugin="example">src</folder>

Expected result AFTER applying this Pull Request

Module(s)

<folder module="mod_example">services</folder>
<folder>src</folder>

Plugin(s)

<folder plugin="example">services</folder>
<folder>src</folder>

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@laoneo
Copy link
Copy Markdown
Member

laoneo commented Mar 26, 2023

Cool, I did it that way to have the folders in alpha order too.

@laoneo laoneo merged commit 20ff4df into joomla:4.4-dev Mar 28, 2023
@laoneo laoneo added this to the Joomla! 4.4.0 milestone Mar 28, 2023
@laoneo
Copy link
Copy Markdown
Member

laoneo commented Mar 28, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants