Add cypress com_banners test#40183
Merged
laoneo merged 11 commits intojoomla:4.4-devfrom Mar 24, 2023
Merged
Conversation
laoneo
reviewed
Mar 23, 2023
tests/System/integration/site/components/com_banner/banner.cy.js
Outdated
Show resolved
Hide resolved
laoneo
reviewed
Mar 23, 2023
tests/System/integration/site/modules/mod_banners/Banners.cy.js
Outdated
Show resolved
Hide resolved
tests/System/integration/site/modules/mod_banners/Banners.cy.js
Outdated
Show resolved
Hide resolved
Member
|
There are still some cs issues and can you rename the file to Default.cy.js. |
Member
|
Thanks a lot! |
Contributor
Author
|
Glad I could help |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for adding cypress test for banners.
@rajputanuj31 @laoneo helped a lot thankyou!