Skip to content

[4.3] Remove redundant assignment#40161

Merged
obuisard merged 4 commits intojoomla:4.3-devfrom
Quy:35752-remove-duplicate-assignment
Mar 26, 2023
Merged

[4.3] Remove redundant assignment#40161
obuisard merged 4 commits intojoomla:4.3-devfrom
Quy:35752-remove-duplicate-assignment

Conversation

@Quy
Copy link
Copy Markdown
Contributor

@Quy Quy commented Mar 21, 2023

Pull Request for Issue #35752.

Summary of Changes

The first assignment is the original and a subset of the 2nd assignment.
Remove the first assignment.

Testing Instructions

Code review.

@richard67
Copy link
Copy Markdown
Member

I have tested this item ✅ successfully on 8757e68


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40161.

1 similar comment
@viocassel
Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on 8757e68


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40161.

@alikon
Copy link
Copy Markdown
Contributor

alikon commented Mar 22, 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40161.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 22, 2023
@Quy Quy added the PR-4.3-dev label Mar 22, 2023
@Quy
Copy link
Copy Markdown
Contributor Author

Quy commented Mar 26, 2023

@obuisard @laoneo Please merge as there was an oversight in the original PR.

@obuisard obuisard added this to the Joomla! 4.3.0 milestone Mar 26, 2023
@obuisard obuisard merged commit b7f4ddf into joomla:4.3-dev Mar 26, 2023
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 26, 2023
@obuisard
Copy link
Copy Markdown
Contributor

Thank you @Quy

@Quy Quy deleted the 35752-remove-duplicate-assignment branch March 26, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants