[5.0] Extending Joomla\CMS\Filesystem\Path from Joomla\Filesystem\Path#40104
Merged
HLeithner merged 2 commits intojoomla:5.0-devfrom Sep 2, 2023
Merged
[5.0] Extending Joomla\CMS\Filesystem\Path from Joomla\Filesystem\Path#40104HLeithner merged 2 commits intojoomla:5.0-devfrom
HLeithner merged 2 commits intojoomla:5.0-devfrom
Conversation
4 tasks
4 tasks
Member
Author
Member
|
I would like to move this class to the combat plugin (same for the other deprecated classes) instead of a silent change |
Member
|
Since this is hard to test because it would effect multiple parts of the CMS I merge this into beta1 to get better real world feedback |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR extends the CMS Path class from the framework Filesystem Path class. This removes all duplicate code from the CMS class, using the framework methods where possible. This means that now this class throws exceptions.
I've changed this a bit agressively, no remaining method stubs with deprecation notices, but I hope that this is still okay.
This PR would be the extension to #40127
Testing Instructions
Codereview
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed