[5.0] Extending Joomla\CMS\Filesystem\Folder from Joomla\Filesystem\Folder#40094
Closed
Hackwar wants to merge 6 commits intojoomla:5.1-devfrom
Closed
[5.0] Extending Joomla\CMS\Filesystem\Folder from Joomla\Filesystem\Folder#40094Hackwar wants to merge 6 commits intojoomla:5.1-devfrom
Hackwar wants to merge 6 commits intojoomla:5.1-devfrom
Conversation
Member
|
That would be a hard b/c break, we have to move all calls in the CMS to the framework or convert exceptions to errors in this class as long as this class exists. can't except this for 5.0 |
Member
|
btw. I think documentation is needed for such a change. |
4 tasks
Member
|
@Hackwar can you get this read till weekend please? |
Member
|
This pull request has been automatically rebased to 5.1-dev. |
Member
Author
|
I doubt this will ever be merged, so I'm closing this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR extends the CMS Folder class from the framework Filesystem Folder class. This removes all duplicate code from the CMS class, using the framework methods where possible. This means that now this class throws exceptions and that all FTP remnants are removed.
Looking at the remaining code, we should consider moving some of this into the framework as well.
I've changed this a bit agressively, no remaining method stubs with deprecation notices, no hints at the removed FTP code, but I hope that this is still okay.
Testing Instructions
Everything should work like before... I think this should rather be done by codereview.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed