[#30472] Cannot cancel Download Tracks in com_banners#4002
Closed
nikosdion wants to merge 1 commit intojoomla:stagingfrom
nikosdion:bugfix/30472-download-tracks-cancel-button
Closed
[#30472] Cannot cancel Download Tracks in com_banners#4002nikosdion wants to merge 1 commit intojoomla:stagingfrom nikosdion:bugfix/30472-download-tracks-cancel-button
nikosdion wants to merge 1 commit intojoomla:stagingfrom
nikosdion:bugfix/30472-download-tracks-cancel-button
Conversation
Joomla! Tracker Item [#30472](http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=30472&start=0) # Executive summary In the back-end, Banners, Track, Export the Cancel button doesn't work. Moreover, once you click on Download the modal doesn't automatically close. # Issue analysis The Javascript on the modal is referencing the no longer used Squeezebox. Since we are now using Bootstrap's modal we merely need to update the Javascript to use $(element).modal.close();
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Joomla! Tracker Item #30472
Executive summary
In the back-end, Banners, Track, Export the Cancel button doesn't work. Moreover, once you click on Download the modal doesn't automatically close.
Issue analysis
The Javascript on the modal is referencing the no longer used Squeezebox. Since we are now using Bootstrap's modal we merely need to update the Javascript to use $(element).modal.close();