[4.2] Update deleted files list in script.php for upcoming 4.2.7#39684
Merged
fancyFranci merged 1 commit intojoomla:4.2-devfrom Jan 22, 2023
Merged
Conversation
2 tasks
Contributor
|
I have tested this item ✅ successfully on bfa638b This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39684. |
1 similar comment
Contributor
|
I have tested this item ✅ successfully on bfa638b This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39684. |
Member
Author
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39684. |
Contributor
|
Thanks a lot for keeping an eye on that list :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
This pull request (PR) updates the list of files to be deleted on update in file "administrator/components/com_admin/script.php" to recent changes in the 4.2-dev branch in preparation for the upcoming 4.2.7 release.
There is only one file from the debugbar dependency to be deleted on update. This is caused by PR #39594 which updated the dependency to a new version. The deleted file has been removed because it belonged to code for PHP versions older than 7.1, which are not supported anymore by the dependency and are also older than the minimum required 7.2 for J4. See this comment here in their PR: php-debugbar/php-debugbar#497 (comment)
Testing Instructions
Code review.
Or if you want to make a real test, update a 4.2.6 or any older 4.x version to the last 4.2-dev nightly build to get the actual result, and update a 4.2.6 or any older 4.x version to the update package built by Drone for this PR to get the expected result.
Actual result BEFORE applying this Pull Request
File "libraries/vendor/maximebf/debugbar/src/DebugBar/DataFormatter/VarDumper/SeekingData.php" is still present after the update.
Expected result AFTER applying this Pull Request
File "libraries/vendor/maximebf/debugbar/src/DebugBar/DataFormatter/VarDumper/SeekingData.php" has been deleted with the update.
Link to documentations
Please select:
No documentation changes for docs.joomla.org needed
No documentation changes for manual.joomla.org needed