Skip to content

[4.2] PHP8.2 Add the missing properties to the installation JSON response#39660

Merged
roland-d merged 2 commits intojoomla:4.2-devfrom
Digital-Peak:php82/installation
Jan 18, 2023
Merged

[4.2] PHP8.2 Add the missing properties to the installation JSON response#39660
roland-d merged 2 commits intojoomla:4.2-devfrom
Digital-Peak:php82/installation

Conversation

@laoneo
Copy link
Copy Markdown
Member

@laoneo laoneo commented Jan 18, 2023

Pull Request for Issue #39655.

Summary of Changes

Adds the missing properties to the installation JSON response.

Testing Instructions

Install Joomla on PHP 8.2.

Actual result BEFORE applying this Pull Request

Deprecate warnings in the Installation step when all data is entered.

Expected result AFTER applying this Pull Request

Joomla installs fine.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@alikon
Copy link
Copy Markdown
Contributor

alikon commented Jan 18, 2023

I have tested this item ✅ successfully on 083d2ff


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39660.

1 similar comment
@degobbis
Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on 083d2ff


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39660.

@Quy Quy added PHP 8 and removed PHP 8.x PHP 8.x deprecated issues labels Jan 18, 2023
@Quy
Copy link
Copy Markdown
Contributor

Quy commented Jan 18, 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39660.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 18, 2023
@Quy Quy added PHP 8.x PHP 8.x deprecated issues and removed PHP 8 labels Jan 18, 2023
@roland-d roland-d merged commit b2b5e6f into joomla:4.2-dev Jan 18, 2023
@roland-d roland-d deleted the php82/installation branch January 18, 2023 14:39
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 18, 2023
@roland-d
Copy link
Copy Markdown
Contributor

Thank you

@roland-d roland-d added this to the Joomla! 4.2.7 milestone Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PHP 8.x PHP 8.x deprecated issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants