[4.3][bug] Refresh list of parent menu items after menu selection has been changed#39659
Merged
obuisard merged 4 commits intojoomla:4.3-devfrom Jan 19, 2023
Merged
Conversation
Contributor
|
I have tested this item ✅ successfully on ad1c257 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39659. |
1 similar comment
Contributor
|
I have tested this item ✅ successfully on ad1c257 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39659. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39659. |
Contributor
|
Thank you David @SniperSister for the bug fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #38792
Summary of Changes
This patch correctly refreshes the list of available parent menu item after the actual menu assignment has been changed. This prevents an incorrect configuration (parent menu item selected which does not belong to the selected menu) being stored.
Testing Instructions
Actual result BEFORE applying this Pull Request
Parent menu select shows menu items of the old menu assignment.
Expected result AFTER applying this Pull Request
Parent menu select shows menu items of the new menu assignment.
Link to documentations