[4.3][bug] fix 5.2 + debug lang#39652
Merged
obuisard merged 8 commits intojoomla:4.3-devfrom Jan 19, 2023
Merged
Conversation
Contributor
|
<tr>
<td>pkg_en-GB.sys</td>
<td>
<ul>
<li class="alert-warning">- /language/en-GB/pkg_en-GB.sys.ini</li>
<li class="alert-warning">- /language/en-GB/en-GB.pkg_en-GB.sys.ini</li>
</ul>
</td>
</tr> |
Contributor
|
|
heelc29
reviewed
Jan 16, 2023
Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>
Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>
Contributor
|
I have tested this item ✅ successfully on d29ea2b Thanks This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39652. |
Contributor
|
I have tested this item ✅ successfully on d29ea2b This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39652. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39652. |
Contributor
|
@dgrammatiko Should this code maybe added to |
Contributor
Author
|
@heelc29 yeah that seems the right place. I already moved the code there, thanks |
Contributor
|
I have tested this item ✅ successfully on 4ea06bb This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39652. |
Member
|
Back to pending. One more human test needed. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39652. |
Contributor
|
I have tested this item ✅ successfully on 4ea06bb This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39652. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39652. |
Contributor
|
Thank you Dimitris @dgrammatiko for the fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #39651 .
Summary of Changes
Testing Instructions
Check the issue
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed