Skip to content

REDO #39353 - Values not translated in com_finder search result#39636

Merged
roland-d merged 2 commits intojoomla:4.2-devfrom
cyrez:patch-53
Jan 16, 2023
Merged

REDO #39353 - Values not translated in com_finder search result#39636
roland-d merged 2 commits intojoomla:4.2-devfrom
cyrez:patch-53

Conversation

@cyrez
Copy link
Copy Markdown
Contributor

@cyrez cyrez commented Jan 15, 2023

REDO #39353
Pull Request for Issue #38846.

Summary of Changes

Translate missing translations of values in search results.

Testing Instructions

  • Needs a multi-language site.
  • Search in frontend.
  • For example with en-GB, fr-FR, de-DE, with a search for Type: Categories.

Actual result BEFORE applying this Pull Request

Before PR, Type: Category for all languages (Category not translated):

en-GB
Capture d’écran 2022-12-04 à 02 19 55

fr-FR
Capture d’écran 2022-12-04 à 02 20 54

de-DE
Capture d’écran 2022-12-04 à 02 19 43

Expected result AFTER applying this Pull Request

After PR, Category is translated:

en-GB
Capture d’écran 2022-12-04 à 02 16 16

fr-FR
Capture d’écran 2022-12-04 à 02 15 47

de-DE
Capture d’écran 2022-12-04 à 02 16 37

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@Kostelano
Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on f3d708b

It works, thanks.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39636.

@viocassel
Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on f3d708b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39636.

@Quy
Copy link
Copy Markdown
Contributor

Quy commented Jan 15, 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39636.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 15, 2023
@cyrez
Copy link
Copy Markdown
Contributor Author

cyrez commented Jan 15, 2023

Thank you @viocassel and @Kostelano for testing! 👍

@roland-d roland-d merged commit 77770e4 into joomla:4.2-dev Jan 16, 2023
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 16, 2023
@roland-d
Copy link
Copy Markdown
Contributor

Thank you for your contribution

@roland-d roland-d added this to the Joomla! 4.2.7 milestone Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants