Skip to content

[4] PHP 8.2 Dynamic property - ModuleorderField#39632

Merged
roland-d merged 4 commits intojoomla:4.2-devfrom
alikon:patch-12
Jan 18, 2023
Merged

[4] PHP 8.2 Dynamic property - ModuleorderField#39632
roland-d merged 4 commits intojoomla:4.2-devfrom
alikon:patch-12

Conversation

@alikon
Copy link
Copy Markdown
Contributor

@alikon alikon commented Jan 15, 2023

Pull Request for Issue php 8.2 - dynamic property Deprecated

Summary of Changes

declared the missed property

Testing Instructions

with php 8.2 with Error Reporting = maximum
credit / edit a module

Actual result BEFORE applying this Pull Request

Deprecated: Creation of dynamic property Joomla\CMS\Form\Field\ModuleorderField::$linked is deprecated

Expected result AFTER applying this Pull Request

no more

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@laoneo laoneo added the PHP 8.x PHP 8.x deprecated issues label Jan 16, 2023
@laoneo
Copy link
Copy Markdown
Member

laoneo commented Jan 16, 2023

Why did you add the AllowDynamicProperties here instead of adding the missed field?

@carlitorweb
Copy link
Copy Markdown
Member

I have tested this item ✅ successfully on 8fa89df


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39632.

@laoneo
Copy link
Copy Markdown
Member

laoneo commented Jan 18, 2023

I have tested this item ✅ successfully on 8fa89df


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39632.

@Quy
Copy link
Copy Markdown
Contributor

Quy commented Jan 18, 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39632.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 18, 2023
@roland-d roland-d merged commit 18d3574 into joomla:4.2-dev Jan 18, 2023
@roland-d
Copy link
Copy Markdown
Contributor

Thank you

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 18, 2023
@roland-d roland-d added this to the Joomla! 4.2.7 milestone Jan 18, 2023
@alikon alikon deleted the patch-12 branch January 18, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PHP 8.x PHP 8.x deprecated issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants